Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Support for Basic Latin Ligatures (\uFB00 to \uFB06). Partially resolves #38 #233

Merged
merged 2 commits into from Apr 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

mdumic commented Feb 12, 2012

Added support for Basic Latin Ligatures (Code points \uFB00 to \uFB06, as per Unicode 6.1 / Latin Ligatures)

The core cufon.js does substitution of letter groups to Unicode ligatures if the font file defines glyphs at those code points.

I left the generator unchanged as it already includes the ligature range if option "all" is checked. Though, it could be improved by adding specific range just for ligatures.

I tested the feature with "PT Sans" (2 glyphs) and "Anivers" (5 glyphs) but I'm not sure these should be included into the project so I left the examples out as Vegur does not have glyphs for ligatures.

Owner

sorccu commented Feb 24, 2012

Hi,

You should be able to update the pull request by simply pushing more commits to the same branch you initiated the pull request from (mdumic:ligatures).

@mdumic mdumic Refactored support for ligatures to support configuration option (ope…
…ning the way for discretionary ligatures). Also, fixed coding style issues with in commit.
91a7c02
Contributor

mdumic commented Mar 8, 2012

Just a note about the commit:

I realized the Font and options are in many-to-many relation (due to the "autoDetect" option), so neither can simply store the other. That made the caching within Font.applyLigatures a little more complicated than I wanted, but I think it's pretty good overall.

@sorccu sorccu added a commit that referenced this pull request Apr 5, 2012

@sorccu sorccu Merge pull request #233 from mdumic/ligatures
Support for Basic Latin Ligatures (\uFB00 to \uFB06). Partially resolves #38
94db085

@sorccu sorccu merged commit 94db085 into sorccu:master Apr 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment