Implement validation for "is rw"

sorear · May 16, 2011 · 622e5dc · 622e5dc
1 parent a2b2f37
commit 622e5dc
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/Kernel.cs b/lib/Kernel.cs
@@ -409,8 +409,7 @@ public class SubInfo {
 
                     // XXX $_ stupidity
                     if (rw && !src.rw)
-                        rw = false;
-                        //return Kernel.Die(th, "Binding " + PName(rbase) + ", cannot bind read-only value to is rw parameter");
+                        return Kernel.Die(th, "Binding " + PName(rbase) + ", cannot bind read-only value to is rw parameter");
                     // fast path
                     if (rw == src.rw && islist == src.islist) {
                         if (!src.type.HasMRO(type)) {

diff --git a/test2.pl b/test2.pl
@@ -157,6 +157,9 @@
     {
         is $_, 5, '$_ passes into bare blocks';
     }
+
+    sub foo($x is rw) { $x }
+    dies_ok { foo 5 }, "cannot rw-bind constant";
 }
 
 #is $?FILE, 'test.pl', '$?FILE works';