Improve handling of my @x in subs

sorear · Jul 20, 2010 · 7b4cabe · 7b4cabe
1 parent fa2393d
commit 7b4cabe
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/CgOp.pm b/CgOp.pm
@@ -313,12 +313,13 @@ use warnings;
           lexput(0, $_[0], protolget($_[0])));
     }
 
-    # this will need changing once @vars are implemented... or maybe something
-    # entirely different, I think cloning at all may be wrong
+    # the handling of @var here is quite wrong, but works for now
     sub copy_lex {
+        my ($n, $l) = @_;
         prog(
-          lextypes($_[0], 'Variable'),
-          lexput(0, $_[0], newrwscalar(fetch(protolget($_[0])))));
+          lextypes($n, 'Variable'),
+          lexput(0, $n, $l ? newrwlistvar(fetch(protolget($_[0])))
+                           : newrwscalar(fetch(protolget($_[0])))));
     }
 
     sub clone_lex {

diff --git a/Decl.pm b/Decl.pm
@@ -123,7 +123,7 @@ use CgOp;
 
         $body->mainline ?
             CgOp::share_lex($self->slot) :
-            CgOp::copy_lex($self->slot);
+            CgOp::copy_lex($self->slot, $self->list);
     }
 
     sub write {