New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function checking for equal levels on factor columns in X and test #30

Merged
merged 1 commit into from Oct 10, 2017

Conversation

Projects
None yet
2 participants
@rragundez
Contributor

rragundez commented Oct 2, 2017

The check that both test and X will have matching levels for factor columns breaks if the levels are the same but in the test some level is not present in the data (which I can imagine happens a lot since the test set is always much smaller). By removing the droplevels function now we really compare the levels on the factors and not the appearance of levels in the data.

Update Xtestmerger.R
The check that both test and X will have matching levels for factor columns breaks if the levels are the same but in the test some level is not present in the data (which I can imagine happens a lot since the test set is always much smaller). By removing the droplevels function now we really compare the levels on the factors and not the appearance of levels in the data.

@sorhawell sorhawell merged commit 428b0d3 into sorhawell:master Oct 10, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sorhawell

This comment has been minimized.

Show comment
Hide comment
@sorhawell

sorhawell Oct 10, 2017

Owner

thx a lot, man :)

Owner

sorhawell commented Oct 10, 2017

thx a lot, man :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment