Tip IDs break popover accessibility via describerdby #596

Open
webgurumike opened this Issue Dec 8, 2016 · 0 comments

Projects

None yet

1 participant

@webgurumike
webgurumike commented Dec 8, 2016 edited

On line 1286 of bootstrap-tour-standalone.js, you are overwriting the popover ID. (e.g. $tip.attr('id', step.id);).

This ID is referenced by the native popover functionality to provide the "describedby" association to the popover for assistive technology.

I would recommend leaving the popover ID alone and possibly use a data attribute instead to manage identifiers.

OR...

You can add the following to the next line:
$element.attr('aria-describedby', step.id);

However, I am unsure how this update would regress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment