Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this an abandoned project? #1239

Closed
facastagnini opened this issue Nov 28, 2016 · 42 comments
Closed

Is this an abandoned project? #1239

facastagnini opened this issue Nov 28, 2016 · 42 comments
Labels

Comments

@facastagnini
Copy link
Collaborator

@facastagnini facastagnini commented Nov 28, 2016

Hi guys,

It seems that @sorin-ionescu is not active anymore. There is a pile of useful PRs and no one with merge rights. Just take a look at the code-frequency...

When a cool project like prezto is abandoned by the repo owner and no one else has commit rights the community should find the way to orderly move forward. Is there a well maintained fork that we can move to or someone willing to do it?

CCing some contributors that I have seen active around here... @rtfpessoa @ezintz @ericbn @joaosa @sectioneight @leoj3n @toogley

PD: @sorin-ionescu are you there? Please drop a line here so we can figure out what to do next!

@rtfpessoa

This comment has been minimized.

Copy link

@rtfpessoa rtfpessoa commented Nov 28, 2016

I only did a fork and started merging some prs but only for private use.

To be fair, I know very few bits of the project so I do not think I would be a good maintainer alternative.

Though, I would not mind helping.

@ericbn

This comment has been minimized.

Copy link

@ericbn ericbn commented Nov 28, 2016

Also CCing everyone from #1163: @kontrafiktion, @kress95, @ezintz, @fuadsaud, @stefanosc.

@toogley

This comment has been minimized.

Copy link

@toogley toogley commented Nov 28, 2016

(Just for reference: I have currently no interest in this project - I Initially, answered with the opposite, because I thought i was tagged for another project i'm interested in. Sorry.)

@ezintz

This comment has been minimized.

Copy link
Contributor

@ezintz ezintz commented Nov 29, 2016

Yes, sure let's see how we can make progress. As most of you probably did, I also merged some of the pull requests which made sense to me. Let me know how I can contribute and support you.

However I will need to keep a separate project as I've integrated it to my dotfiles to take my configuration always with me.

@stefanosc

This comment has been minimized.

Copy link

@stefanosc stefanosc commented Nov 29, 2016

Thank you for this conversation. Unfortunately, I have not been active at all in development for almost 18 months. I am still using prezto and the sorin theme despite the lack of commits / merged pull requests.
I would have already moved to zim if it wasn't for this: zimfw/zimfw#82
I don't know how helpful I could be, however if others are interested I could try. To me it makes more sense to move to zim and integrate the missing pieces.

@rjcoelho

This comment has been minimized.

Copy link

@rjcoelho rjcoelho commented Nov 29, 2016

@stefanosc why zim since its basically same as prezto ? why not zgen or antigen instead ?

@stefanosc

This comment has been minimized.

Copy link

@stefanosc stefanosc commented Nov 29, 2016

@rjcoelho this sums it up (first paragraph from readme):

Zim is a Zsh configuration framework with blazing speed and modular extensions.

Zim is very easy to customize, and comes with a rich set of modules and features without compromising on speed or functionality!

It seems to me zim is trying to bring prezto back to the origin or even take it further, in terms of simplicity and speed, which were among the main reasons sorin moved away from omzsh.
It is actively developed and is a little more than a plugin manager (zgen or antigen)

What is your take?

@jeffcox

This comment has been minimized.

Copy link

@jeffcox jeffcox commented Nov 29, 2016

I've had no issues running a personal fork and perusing the discussions and PRs here. What do people expect to see? Changing dotfiles for the sake of it doesn't make sense to me.

@dvcrn

This comment has been minimized.

Copy link

@dvcrn dvcrn commented Nov 30, 2016

It's a shame @sorin-ionescu doesn't just add some of the people here as maintainers.

Given the MIT license, how about we move it into a org and add all people here interested in maintaining as initial members? I played with org-settings and it looks feasible.

  • Are there people here willing to take over the wheel of this project?
  • Does the MIT license permit publicly distributing a fork under the same name?
  • Would the name-clash be a problem? New users would very likely be confused about this

/edit: I had some time to try out zim and really like it so far as well!

@ezintz

This comment has been minimized.

Copy link
Contributor

@ezintz ezintz commented Dec 1, 2016

@dvcrn nice to meet you here (; However I like your idea about moving to an organisation.

I just had a short look at the zim source code and I have to say it looks pretty similar to prezto.

@stefanosc

This comment has been minimized.

Copy link

@stefanosc stefanosc commented Dec 1, 2016

@ezintz zim started as a fork of prezto due to sorin lack of activity: take a look at @Eriner fork:
https://github.com/Eriner/prezto (read the NOTICE at the beginning of the readme)

@facastagnini

This comment has been minimized.

Copy link
Collaborator Author

@facastagnini facastagnini commented Dec 1, 2016

I also like @dvcrn 's idea. I just created one here https://github.com/prezto-users and forked the repo.
Lets make this a community effort, so far I am the only one there, please let me know if any of you wants to be a contributor.

EDIT: I haven't done any change to the fork until we have a few members that can review the PRs

@Eriner

This comment has been minimized.

Copy link
Contributor

@Eriner Eriner commented Dec 2, 2016

For those curious about zim, @stefanosc nailed it. I've been busy at work recently, but I'm going to carve out time this weekend to wrap up moving the project into an organization (which requires some additional code, hence the delay). I've been putting off doing that for far too long now. This will ultimately end up in this organization/repository. The change to an organization should facilitate better project growth and management.

That said, I think zim is a great choice for most people currently looking for a prezto alternative/replacement. When the change happens, I will do my best to make the transition to the new repository/organization/structure as seamless as possible.

@stefanosc, if you'd be interested in beginning work on providing the changes for the issue you mentioned, I'd be glad to merge them into the project.

@ryankask

This comment has been minimized.

Copy link

@ryankask ryankask commented Dec 2, 2016

It would be great to learn more about how to transition from prezto to zim.

Is zim meant to be forked? For example, I have a custom prompt theme -- where do I put that? I just added it to modules/prompt/functions in my prezto fork.

Also, how do the contents of prezto's runcoms directory map to zim's templates directory? Clearly zimrc is zpreztorc and zshrc is the same but what about zprofile? In prezto this sets up paths and exports important variables like EDITOR. Where should the contents of that file go in zim? Is zshenv necessary?

Thanks!

@dvcrn

This comment has been minimized.

Copy link

@dvcrn dvcrn commented Dec 2, 2016

@ryankask from what I can see, zshrc is sourcing zim (and therefore zimrc). So zimrc would be zpreztorc and zshrc is your normal zshrc.
It's almost identical to prezto in that you can fork it - implying the occasional upstream commit merging, or just go with the upstream version.

@Eriner if you ever need a helping hand with zim, I would love to help as well 😊

@facastagnini

This comment has been minimized.

Copy link
Collaborator Author

@facastagnini facastagnini commented Dec 4, 2016

@nicoulaj https://github.com/zsh-users sounds like the appropriated organization to keep a project under the zsh community, can we fork this repo into it?
I would like to be a maintainer if you dont mind.
Thanks a lot!

Edit: I started https://github.com/organizations/prezto-users but then I found zsh-users, I would remove it if I can migrate to it.

@nicoulaj

This comment has been minimized.

Copy link
Contributor

@nicoulaj nicoulaj commented Dec 4, 2016

It looks like @sorin-ionescu was active one week ago, and this issue is only 6 days old, can you guys give him some time to answer before forking ?
If he wants to move the project to zsh-users, of course it is welcome here.
He also is an administrator of the zsh-users organization anyway.

I'm idling on IRC (#zsh-users) if any help is needed.

@stefanosc

This comment has been minimized.

Copy link

@stefanosc stefanosc commented Dec 4, 2016

@Eriner thank you for your work and offer. I see @ericbn already submitted a cool PR zimfw/zimfw#104
I don't think I can do better / more at this time. Thank you both very much

@facastagnini

This comment has been minimized.

Copy link
Collaborator Author

@facastagnini facastagnini commented Dec 4, 2016

@nicoulaj sure, lets wait one week to give @sorin-ionescu an opportunity

@rjcoelho

This comment has been minimized.

Copy link

@rjcoelho rjcoelho commented Dec 14, 2016

I vote for 1) moving prezto into git to https://github.com/zsh-users, and 2) when possible convert prezto modules into external zsh-users repos to be used outside prezto and to avoid "add xpto module PR".

@phretor

This comment has been minimized.

Copy link

@phretor phretor commented Dec 14, 2016

👍

@facastagnini

This comment has been minimized.

Copy link
Collaborator Author

@facastagnini facastagnini commented Dec 15, 2016

@nicoulaj should we make the move? We are a handful of contributors waiting for a resolution to start reviewing the accumulated PRs :)

@nicoulaj

This comment has been minimized.

Copy link
Contributor

@nicoulaj nicoulaj commented Dec 20, 2016

OK, I created the fork at https://github.com/zsh-users/prezto and invited the people from this thread who expressed interest in helping.

If you need anything, please let know.

About the idea to turn modules into individual repos: this will require that you have admin access on the zsh-users organization. So I would prefer to first wait for things to stabilize, and wait for the project to have a stable team/trusted admins ;)

@facastagnini

This comment has been minimized.

Copy link
Collaborator Author

@facastagnini facastagnini commented Dec 21, 2016

Thanks @nicoulaj for providing a home for this project, and thanks to all those who participated in the conversation!

Now its time to work. The holidays are going to keep me distracted, but I will spend some time in the next couple weeks reviewing the old PRs and submitting them in the new repo.

@facastagnini

This comment has been minimized.

Copy link
Collaborator Author

@facastagnini facastagnini commented Dec 29, 2016

Reopening so people can find this easily

@sorin-ionescu

This comment has been minimized.

Copy link
Owner

@sorin-ionescu sorin-ionescu commented Mar 10, 2017

@facastagnini I welcome your enthusiasm for this project, and I thank you for picking up the slack. I wish you had sent me an email directly instead of relying on GitHub notifications. If you did, I did not see it. I would have given you access or moved the repository to zsh-users myself since it has become big enough.

@Eriner What happened to the author list comment at the top of files in Zim?

@Eriner

This comment has been minimized.

Copy link
Contributor

@Eriner Eriner commented Mar 10, 2017

@sorin-ionescu zim has never had an "author list" at the top of files, so I don't know what you're talking about. I think this is a silly practice; IMO people should simply use git, as that's how the rest of the project is managed.

@antoineco

This comment has been minimized.

Copy link

@antoineco antoineco commented Mar 10, 2017

@Eriner Sorin actually meant "you copied my code and didn't mention its original author", I think.

@Eriner

This comment has been minimized.

Copy link
Contributor

@Eriner Eriner commented Mar 10, 2017

@antoineco I didn't copy prezto code, aside from places where attribution has been given. I did adopt the code/file structure used by prezto; it's the optimal way to organize the project.

@antoineco

This comment has been minimized.

Copy link

@antoineco antoineco commented Mar 10, 2017

@Eriner I was not giving my opinion just trying to clarify the message which got apparently misunderstood. Sorry if it sounded otherwise!

@sorin-ionescu

This comment has been minimized.

Copy link
Owner

@sorin-ionescu sorin-ionescu commented Mar 10, 2017

@Eriner

This comment has been minimized.

Copy link
Contributor

@Eriner Eriner commented Mar 11, 2017

@Eriner I was not giving my opinion just trying to clarify the message which got apparently misunderstood. Sorry if it sounded otherwise!

Nope, I got it, just wanted to clear everything up 👍

The rationale behind having the author list at the top of files in Prezto, since nobody bothers to check the Git log to see who submitted a module first, is that users would contact the authors of a module directly via the issue system, which would respond faster than me.

This makes sense, and is semi-related to one of the reasons we're in the process of transitioning zim to it's own organization, that way modules can be assigned to specific authors/maintainers, and the issue tracker can be used directly without overwhelming anyone. :)

Since Zim is Prezto-inspired, not a fork, and your turf, manage it however you please. I'm not imposing my views on you.
Prezto and Zim should keep a dialogue open.

Cool, appologies if my statement came off as too direct; I had just addressed the same comment a few days ago and felt as if I was repeating myself :P

Cheers

@belak

This comment has been minimized.

Copy link
Collaborator

@belak belak commented Apr 5, 2017

I'm going to close this now because there have been a number of additional maintainers added and we've started managing pull requests.

This project is still alive and will hopefully have more activity from now on.

@Po-Hsuan-Huang

This comment has been minimized.

Copy link

@Po-Hsuan-Huang Po-Hsuan-Huang commented Apr 19, 2017

Can someone change the title of the issue ? It is quite confusing for new comers. It is not necessary to read this before opening a issue anymore.

@belak belak changed the title READ ME BEFORE OPENING AN ISSUE: Is this an abandoned project. Is this an abandoned project? Apr 19, 2017
@belak

This comment has been minimized.

Copy link
Collaborator

@belak belak commented Apr 19, 2017

It shouldn't show up for most people, as it's been closed. I changed the title to make it clearer though.

AndrewSB added a commit to AndrewSB/dotfiles that referenced this issue Sep 23, 2017
@zx1986

This comment has been minimized.

Copy link

@zx1986 zx1986 commented Sep 28, 2018

So, we keep use this repo, right?
Thank you all!

@sorin-ionescu

This comment has been minimized.

Copy link
Owner

@sorin-ionescu sorin-ionescu commented Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.