-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this an abandoned project? #1239
Comments
I only did a fork and started merging some prs but only for private use. To be fair, I know very few bits of the project so I do not think I would be a good maintainer alternative. Though, I would not mind helping. |
Also CCing everyone from #1163: @kontrafiktion, @kress95, @ezintz, @fuadsaud, @stefanosc. |
(Just for reference: I have currently no interest in this project - I Initially, answered with the opposite, because I thought i was tagged for another project i'm interested in. Sorry.) |
Yes, sure let's see how we can make progress. As most of you probably did, I also merged some of the pull requests which made sense to me. Let me know how I can contribute and support you. However I will need to keep a separate project as I've integrated it to my dotfiles to take my configuration always with me. |
Thank you for this conversation. Unfortunately, I have not been active at all in development for almost 18 months. I am still using prezto and the sorin theme despite the lack of commits / merged pull requests. |
@stefanosc why zim since its basically same as prezto ? why not zgen or antigen instead ? |
@rjcoelho this sums it up (first paragraph from readme):
It seems to me zim is trying to bring prezto back to the origin or even take it further, in terms of simplicity and speed, which were among the main reasons sorin moved away from omzsh. What is your take? |
I've had no issues running a personal fork and perusing the discussions and PRs here. What do people expect to see? Changing dotfiles for the sake of it doesn't make sense to me. |
It's a shame @sorin-ionescu doesn't just add some of the people here as maintainers. Given the MIT license, how about we move it into a org and add all people here interested in maintaining as initial members? I played with org-settings and it looks feasible.
/edit: I had some time to try out zim and really like it so far as well! |
@dvcrn nice to meet you here (; However I like your idea about moving to an organisation. I just had a short look at the zim source code and I have to say it looks pretty similar to prezto. |
@ezintz zim started as a fork of prezto due to sorin lack of activity: take a look at @Eriner fork: |
I also like @dvcrn 's idea. I just created one here https://github.com/prezto-users and forked the repo. EDIT: I haven't done any change to the fork until we have a few members that can review the PRs |
For those curious about zim, @stefanosc nailed it. I've been busy at work recently, but I'm going to carve out time this weekend to wrap up moving the project into an organization (which requires some additional code, hence the delay). I've been putting off doing that for far too long now. This will ultimately end up in this organization/repository. The change to an organization should facilitate better project growth and management. That said, I think zim is a great choice for most people currently looking for a prezto alternative/replacement. When the change happens, I will do my best to make the transition to the new repository/organization/structure as seamless as possible. @stefanosc, if you'd be interested in beginning work on providing the changes for the issue you mentioned, I'd be glad to merge them into the project. |
It would be great to learn more about how to transition from prezto to zim. Is zim meant to be forked? For example, I have a custom prompt theme -- where do I put that? I just added it to modules/prompt/functions in my prezto fork. Also, how do the contents of prezto's runcoms directory map to zim's templates directory? Clearly zimrc is zpreztorc and zshrc is the same but what about zprofile? In prezto this sets up paths and exports important variables like EDITOR. Where should the contents of that file go in zim? Is zshenv necessary? Thanks! |
@ryankask from what I can see, zshrc is sourcing zim (and therefore zimrc). So zimrc would be zpreztorc and zshrc is your normal zshrc. @Eriner if you ever need a helping hand with zim, I would love to help as well 😊 |
@nicoulaj https://github.com/zsh-users sounds like the appropriated organization to keep a project under the zsh community, can we fork this repo into it? Edit: I started https://github.com/organizations/prezto-users but then I found zsh-users, I would remove it if I can migrate to it. |
It looks like @sorin-ionescu was active one week ago, and this issue is only 6 days old, can you guys give him some time to answer before forking ? I'm idling on IRC ( |
@Eriner thank you for your work and offer. I see @ericbn already submitted a cool PR zimfw/zimfw#104 |
@nicoulaj sure, lets wait one week to give @sorin-ionescu an opportunity |
I vote for 1) moving prezto into git to https://github.com/zsh-users, and 2) when possible convert prezto modules into external zsh-users repos to be used outside prezto and to avoid "add xpto module PR". |
👍 |
@nicoulaj should we make the move? We are a handful of contributors waiting for a resolution to start reviewing the accumulated PRs :) |
OK, I created the fork at https://github.com/zsh-users/prezto and invited the people from this thread who expressed interest in helping. If you need anything, please let know. About the idea to turn modules into individual repos: this will require that you have admin access on the zsh-users organization. So I would prefer to first wait for things to stabilize, and wait for the project to have a stable team/trusted admins ;) |
Thanks @nicoulaj for providing a home for this project, and thanks to all those who participated in the conversation! Now its time to work. The holidays are going to keep me distracted, but I will spend some time in the next couple weeks reviewing the old PRs and submitting them in the new repo. |
Reopening so people can find this easily |
@facastagnini I welcome your enthusiasm for this project, and I thank you for picking up the slack. I wish you had sent me an email directly instead of relying on GitHub notifications. If you did, I did not see it. I would have given you access or moved the repository to zsh-users myself since it has become big enough. @Eriner What happened to the author list comment at the top of files in Zim? |
@sorin-ionescu zim has never had an "author list" at the top of files, so I don't know what you're talking about. I think this is a silly practice; IMO people should simply use git, as that's how the rest of the project is managed. |
@Eriner Sorin actually meant "you copied my code and didn't mention its original author", I think. |
@antoineco I didn't copy prezto code, aside from places where attribution has been given. I did adopt the code/file structure used by prezto; it's the optimal way to organize the project. |
@Eriner I was not giving my opinion just trying to clarify the message which got apparently misunderstood. Sorry if it sounded otherwise! |
The rationale behind having the author list at the top of files in Prezto, since nobody bothers to check the Git log to see who submitted a module first, is that users would contact the authors of a module directly via the issue system, which would respond faster than me.
Since Zim is Prezto-inspired, not a fork, and your turf, manage it however you please. I'm not imposing my views on you.
Prezto and Zim should keep a dialogue open.
]]>
|
Nope, I got it, just wanted to clear everything up 👍
This makes sense, and is semi-related to one of the reasons we're in the process of transitioning zim to it's own organization, that way modules can be assigned to specific authors/maintainers, and the issue tracker can be used directly without overwhelming anyone. :)
Cool, appologies if my statement came off as too direct; I had just addressed the same comment a few days ago and felt as if I was repeating myself :P Cheers |
I'm going to close this now because there have been a number of additional maintainers added and we've started managing pull requests. This project is still alive and will hopefully have more activity from now on. |
Can someone change the title of the issue ? It is quite confusing for new comers. It is not necessary to read this before opening a issue anymore. |
It shouldn't show up for most people, as it's been closed. I changed the title to make it clearer though. |
Basically because sorin-ionescu/prezto#1239
So, we keep use this repo, right? |
Yes, we keep the repository. The project has maintainers and is getting
commitments. We must prioritize bug fixes over new features.
…On Fri, Sep 28, 2018 at 11:41 張旭 ***@***.***> wrote:
So, we keep use this repo, right?
Thank you all!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1239 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFueCL_Wb6ZMY-q2lBD5ETL6SxW7tHFks5ufkNBgaJpZM4K94Jm>
.
|
Hi guys,
It seems that @sorin-ionescu is not active anymore. There is a pile of useful PRs and no one with merge rights. Just take a look at the code-frequency...
When a cool project like prezto is abandoned by the repo owner and no one else has commit rights the community should find the way to orderly move forward. Is there a well maintained fork that we can move to or someone willing to do it?
CCing some contributors that I have seen active around here... @rtfpessoa @ezintz @ericbn @joaosa @sectioneight @leoj3n @toogley
PD: @sorin-ionescu are you there? Please drop a line here so we can figure out what to do next!
The text was updated successfully, but these errors were encountered: