Make sure lines are less 80 characters long #258

Closed
sorin-ionescu opened this Issue Sep 1, 2012 · 5 comments

Comments

Projects
None yet
2 participants
Owner

sorin-ionescu commented Sep 1, 2012

Some lines are hard to read, and I am tired of maximising the Terminal window to see them.

I was going to try to help here, but I was wondering how aggressive I should be, for example:

# In init.zsh
   fpath=(${pmodules:+${ZDOTDIR:-$HOME}/.zprezto/modules/${^pmodules}/functions(/FN)} $fpath)

## could be...
   fpath=(
    ${pmodules:+${ZDOTDIR:-$HOME}/.zprezto/modules/${^pmodules}/functions(/FN)}
    $fpath)


# In init.zsh
    for pfunction in ${ZDOTDIR:-$HOME}/.zprezto/modules/${^pmodules}/functions/$~pfunction_glob; do
      autoload -Uz "$pfunction"
    done

### could turn to

    for pfunction in \
      ${ZDOTDIR:-$HOME}/.zprezto/modules/${^pmodules}/functions/$~pfunction_glob
    do
      autoload -Uz "$pfunction"
    done

I don't know maybe that's a bit too much? Anyway... I was thinking in making a PR with various commits (one per file?) so you can check them and makes cherry-picking easier. Is that ok?

Owner

sorin-ionescu commented Oct 28, 2013

It is not a priority to make sure lines are less than 80 characters long. Perhaps, it is also not realistic. If it decreases readability, it should not be done.

Sure, I totally I understand that. I'll keep that in mind when doing it if
you are still interested.

I can make a commit for each file so it's easier to review, so you can take
a look at the proposed changes. Is that ok?

Owner

sorin-ionescu commented Oct 30, 2013

It is not necessary to make a commit for each file.

On Oct 29, 2013, at 9:29, Pablo Olmos de Aguilera Corradini notifications@github.com wrote:

Sure, I totally I understand that. I'll keep that in mind when doing it if
you are still interested.

I can make a commit for each file so it's easier to review, so you can take
a look at the proposed changes. Is that ok?

Reply to this email directly or view it on GitHub.

Owner

sorin-ionescu commented Jan 4, 2014

It's not worth the trouble. Readability is decreased in certain cases.

kodelint pushed a commit to kodelint/prezto that referenced this issue Nov 15, 2016

Merge pull request #258 from felixbuenemann/fix-pgsql-utils-typo
Fix typo in _pgsql_utils --disable-dollar-quoting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment