support virtualenvwrapper when installed in bash_completion.d #238

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jamescasbon

support virtualenvwrapper when installed in bash_completion.d

James Casbon Update modules/python/init.zsh
support virtualenvwrapper when installed in bash_completion.d
96753dc
@lunaryorn

This branch is also entered if $WORKON_HOME is unset. In this case virtualenvwrapper is not configured and sourcing it makes absolutely no sense. It will actually fail and display an error message.

Fix the condition to only fall back to bash_completion.d if (( $+commands[virtualenvwrapper.sh] )) fails.

@lunaryorn
Contributor

How did you install virtualenvwrapper.sh that it ends up in bash_completion.d? It this some distribution package?

If yes, please ask the maintainer for what reason this location was chosen. virtualenvwrapper.sh is no completion script and not bash specific. It doesn't belong into this directory.

@sorin-ionescu
Owner

I agree with @lunaryorn. How in the world did virtualenvwrapper get into that path? I will not be merge this.

@lunaryorn
Contributor

@sorin-ionescu Did a little research, and guess what, it's a Debian mess... would have bet on this.

@jamescasbon Tell Debian to fix their package. Meanwhile keep your own fork with your patch included.

@jamescasbon

I thought it might be easier to get you to patch the init, than debian to change the location. They went to the effort of patching upstream so are probably not going to change it back for me.

Oh well.

@jamescasbon

Debian's bug reporting is so crap I can't even report it!

@lunaryorn
Contributor

Then write to the package manager directly.

@kodelint kodelint pushed a commit to kodelint/prezto that referenced this pull request Nov 15, 2016
@danielshahaf danielshahaf tests: Add two XFail tests for issue #238, "fd redirections at comman…
…d word".
48ecd29
@kodelint kodelint pushed a commit to kodelint/prezto that referenced this pull request Nov 15, 2016
@danielshahaf danielshahaf Fix part of issue #238, "fd redirections at command word".
This fixes fd's specified by a (single) digit.  The named fd syntax remains an XFail.
73ee7c1
@kodelint kodelint pushed a commit to kodelint/prezto that referenced this pull request Nov 15, 2016
@danielshahaf danielshahaf 'main': Enable test for issue #238. fa57633
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment