Richard Marko sorki

Organizations

@hackerspace @abrt
sorki commented on pull request abrt/faf#431
@sorki

add to whitelist

@sorki
@sorki
@sorki
  • @sorki 10760a0
    prefix faf specific roles
sorki pushed to master at abrt/faf
@sorki
sorki merged pull request abrt/faf#430
@sorki
pyfaf: realtime fedmsg notifications
1 commit with 135 additions and 3 deletions
sorki opened issue alexrj/Slic3r#2803
@sorki
Option to disable retract on supports
sorki commented on pull request abrt/abrt#952
@sorki

I think it would be better if 96a1bb0 is split into two patches - one fixing simlink races and the oher one disabling java log saving.

sorki commented on pull request abrt/abrt#952
@sorki

Care to explain how does 217e822 (ccpp: create dump directory without parents) makes the code safer?

sorki commented on commit abrt/libreport@fde67b93bf
@sorki

Please rephrase the commit message to "... without parents".

sorki commented on pull request abrt/libreport#346
@sorki

Otherwise fine. Should probably also include hardening patches from rhel7_copy_file_chown branch and vice-versa if applicable (dump proc data patch).

sorki commented on pull request abrt/libreport#346
@sorki

Typo in commit message of 5797c06 - "rebost".

sorki commented on pull request abrt/libreport#344
@sorki

Looks good to me.

sorki commented on pull request abrt/libreport#347
@sorki

Please wrap lines to 80 chars and squash the "fix -" commit into previous one. Otherwise fine.

sorki commented on pull request abrt/libreport#343
@sorki

Went through the code and it seems to mitigate time of check / time of use race conditions and improve malicious path handling. Ack.

sorki commented on pull request abrt/libreport#343
@sorki

This imo deservers a docstring.

sorki commented on pull request abrt/libreport#343
@sorki

This for should be enough ^^, you don't have to check for /, ./ , ../ cases separately. Also why there's a limit of 61 characters?

sorki pushed to master at abrt/faf
@sorki
sorki merged pull request abrt/faf#426
@sorki
Fedmsg notify
2 commits with 227 additions and 25 deletions
sorki commented on pull request abrt/faf#428
@sorki

Please use += 1 instead of these ^^, otherwise ok.

sorki pushed to master at abrt/faf
@sorki
sorki merged pull request abrt/faf#427
@sorki
Fix retrace
2 commits with 3 additions and 2 deletions
sorki closed issue abrt/faf#425
@sorki
centos7
sorki commented on issue abrt/faf#425
@sorki

Yes, we do support centos7.

sorki created branch test_infra at abrt/abrt-ansible
@sorki
  • @sorki e99ce2f
    apply common role before smtp
@sorki

(Created these issues based on discussion of current state of dist-git so we won't forget on these possible improvements. I might be able to contri…