Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending webhook notification exceeds 2000 character limit #2

Closed
Bartkk0 opened this issue Dec 30, 2021 · 7 comments · Fixed by #4 or #5
Closed

Sending webhook notification exceeds 2000 character limit #2

Bartkk0 opened this issue Dec 30, 2021 · 7 comments · Fixed by #4 or #5
Assignees
Labels
bug Something isn't working

Comments

@Bartkk0
Copy link

Bartkk0 commented Dec 30, 2021

image

@Sorok-Dva
Copy link
Owner

Hello, please could you send a screenshot of your domains list (keep them secret) on freenom ? Maybe you have to much domains so that's why you have this error, and I'll need to divide the message if it's the case.

@Sorok-Dva Sorok-Dva self-assigned this Jan 10, 2022
@Sorok-Dva Sorok-Dva added the bug Something isn't working label Jan 10, 2022
@Bartkk0
Copy link
Author

Bartkk0 commented Jan 11, 2022

I have 28 domains on freenom in total, so it's probably too much.

@Sorok-Dva
Copy link
Owner

Ok yes this is probably where is the problem. I'll push a fix this week (probably this week-end)

@Sorok-Dva
Copy link
Owner

Hello @Bartkk0, please could you test on this branch https://github.com/Sorok-Dva/freenom-auto-renew-domains/tree/fix/webhookContentSize if you now have still the problem please.

I did some tries with some lorem ipsum texts and it's working, all domains are sent one per one, but I don't know if it's working as expected without the lorem ipsum

image

Each blocks is a single discord message

@Bartkk0
Copy link
Author

Bartkk0 commented Feb 21, 2022

Sorry for not replying, tried the branch and it appears that length error was fixed, but now it sends 5 messages and then it's rate limited.
image

@Bartkk0
Copy link
Author

Bartkk0 commented Feb 21, 2022

Fixed it somewhat in #4

@Sorok-Dva
Copy link
Owner

Hello, no problem, thanks for your test and your adjustment, your edits seems good so I'll merge your fix ! Thanks for helping me to improve this tool !

@Sorok-Dva Sorok-Dva linked a pull request Feb 22, 2022 that will close this issue
@Sorok-Dva Sorok-Dva linked a pull request Feb 22, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants