Splay Tree#9
Merged
Merged
Conversation
… quasi nothing reviewd)
…orrect compilation)
Owner
|
Can you fix the build error before merging? |
Collaborator
Author
|
I fixed this by uncovering the other file I hid |
sorrachai
reviewed
May 21, 2026
| /-- BST invariant parameterised by optional lower/upper key bounds. | ||
| `IsBSTAux t lb ub` holds iff every key in `t` lies strictly in `(lb, ub)` | ||
| (absent bound = ±∞) and children satisfy the BST property recursively. -/ | ||
| def IsBSTAux [LinearOrder α] : Tree α → Option α → Option α → Prop |
Owner
There was a problem hiding this comment.
Can you define this Prop inductively? An inductive type is better with proofs. If you need computation, you can write a separate algorithm to check whether it is a BST.
Collaborator
Author
There was a problem hiding this comment.
the proofs have been shortened with this def, but I can try to see what happens with another def.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update notation + IsBST def