Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster domain cannot be configured for clean up job #99

Closed
luischre opened this issue Mar 11, 2022 · 0 comments · Fixed by #101
Closed

Cluster domain cannot be configured for clean up job #99

luischre opened this issue Mar 11, 2022 · 0 comments · Fixed by #101

Comments

@luischre
Copy link
Contributor

Summary

Currently there is no way to configure the cluster domain for the clean up run. Hence the clean up job fails if it is running within a cluster that doesn't have the cluster domain cluster.local

Could not resolve host: sorry-cypress-2-api.sorry-cypress-2.svc.cluster.local

How to reproduce

Deploy the sorry-cypress charts on a cluster with a different cluster domain.

From what I can see this is due to this line within the cronjob-run-cleaner.yml

- name: sorry_cypress_api_url
  value: "http://{{ include "sorry-cypress-helm.fullname" . }}-api.{{ .Release.Namespace }}.svc.cluster.local:4000"

Instead it should be possible to set the cluster domain as a value:

- name: sorry_cypress_api_url
  value: "http://{{ include "sorry-cypress-helm.fullname" . }}-api.{{ .Release.Namespace }}.svc.{{ .Values.runCleaner.clusterDomain }}:4000"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant