Support for getting books from a particular shelf / support for OAuth and getting the id of the auth'd user. #2

Merged
merged 3 commits into from Dec 10, 2012

Conversation

Projects
None yet
2 participants
Contributor

thegreatape commented Dec 10, 2012

Hello! I needed a couple things for a project of mine that weren't covered in this gem's use of the Goodreads API, so I've added them.

Particularly, there's now support for:

  • Paging through the entirety of a particular shelf.
  • Some internal methods for making OAuth requests.
  • Getting the Goodreads id of whoever authorized said OAuth request.
Owner

sosedoff commented Dec 10, 2012

Hey, seems like your PR failed, check build log for 1.8.7 and REE - https://travis-ci.org/sosedoff/goodreads/builds/3584582

Contributor

thegreatape commented Dec 10, 2012

Yep, I'd neglected to run the tests under Ruby < 1.9.3. Sorry about that! Should be fixed now.

@sosedoff sosedoff added a commit that referenced this pull request Dec 10, 2012

@sosedoff sosedoff Merge pull request #2 from thegreatape/master
Support for getting books from a particular shelf / support for OAuth and getting the id of the auth'd user.
d837dd7

@sosedoff sosedoff merged commit d837dd7 into sosedoff:master Dec 10, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment