Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EstimatedTableRowsCount to avoid count in large tables #366

Merged
merged 5 commits into from Jun 18, 2018

Conversation

Projects
None yet
3 participants
@allisson
Copy link
Contributor

commented Jun 14, 2018

Fix #168

@wiliamsouza

This comment has been minimized.

Copy link

commented Jun 14, 2018

Can you provide some tests?

@allisson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2018

@wiliamsouza test_EstimatedTableRowsCount 👍

@sosedoff

This comment has been minimized.

Copy link
Owner

commented Jun 15, 2018

Looks good, i'd add a test to verify TableRowsCount works with a large table, which you can create and fill dynamically.

@allisson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 15, 2018

@sosedoff sounds good.

@allisson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2018

@sosedoff Take a look at the tests

@sosedoff

This comment has been minimized.

Copy link
Owner

commented Jun 16, 2018

Tests look good. I think you forgot to include schema name in the estimated row count sql query.

@allisson

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2018

@sosedoff done 👍

@sosedoff sosedoff merged commit 41a99be into sosedoff:master Jun 18, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.