Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQL export filename #438

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@sd65
Copy link

commented Jul 31, 2019

Hi,

The browser CSV export is a bit broken because the filename passed in headers was mangled. Example :
Content-Disposition: attachment; filename="postgres_"schema"."table".sql.gz"

This PR fixes this.

Sylvain DOIGNON

@sd65 sd65 closed this Jul 31, 2019

@sd65 sd65 reopened this Jul 31, 2019

@sosedoff sosedoff merged commit 1e4a09d into sosedoff:master Aug 1, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@sd65

This comment has been minimized.

Copy link
Author

commented Aug 1, 2019

Great, thanks.

When do you plan to make a new release ?

@sosedoff

This comment has been minimized.

Copy link
Owner

commented Aug 1, 2019

There's another pg_dump related bug that i need to finish first, then i can cut a new release.
Could do that on friday.

@sd65

This comment has been minimized.

Copy link
Author

commented Aug 1, 2019

Excellent news !
Don't hurry, I was just wondering for your releases lifecycle : )

@sosedoff

This comment has been minimized.

Copy link
Owner

commented Aug 1, 2019

Ha, my release lifecycle is pretty much whatever i feel like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.