Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cluster] call crm_report with --sos-mode option #795

Closed
pmoravec opened this issue Apr 8, 2016 · 1 comment
Closed

[cluster] call crm_report with --sos-mode option #795

pmoravec opened this issue Apr 8, 2016 · 1 comment

Comments

@pmoravec
Copy link
Contributor

pmoravec commented Apr 8, 2016

crm_report has been extended ([1]) by option --sos-mode to collect all log files or N-last_lines in log files instead of parsing for a time period. sos should call crm_report using that option.

Option is safe to handle prior to any pacemaker update due to the way crm_report does its option processing (unknown options are discarded and the command executes as normal).

[1] ClusterLabs/pacemaker@1bcad6a

@pmoravec
Copy link
Contributor Author

pmoravec commented Apr 8, 2016

Trivial patch:

diff --git a/sos/plugins/cluster.py b/sos/plugins/cluster.py
index f52f154..3fa84ae 100644
--- a/sos/plugins/cluster.py
+++ b/sos/plugins/cluster.py
@@ -120,7 +120,8 @@ class Cluster(Plugin, RedHatPlugin):
             self._log_warn("scrubbing of crm passwords has been disabled:")
             self._log_warn("data collected by crm_report may contain"
                            " sensitive values.")
-        self.add_cmd_output('crm_report %s -S -d --dest %s --from "%s"' %
+        self.add_cmd_output('crm_report --sos-mode %s -S -d '
+                            '--dest %s --from "%s"' %
                             (crm_scrub, crm_dest, crm_from),
                             chroot=self.tmp_in_sysroot())

Once cluster plugin split [1] will be committed, the same change needs to be done in sos/plugins/pacemaker.py

[1] 44fff9d

pmoravec added a commit to pmoravec/sos that referenced this issue Jun 2, 2016
crm_report should be called with --sos-mode option for preffered
collection of log files.

Resolves: sosreport#795

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
TurboTurtle pushed a commit to TurboTurtle/sos that referenced this issue Jul 13, 2016
crm_report should be called with --sos-mode option for preffered
collection of log files.

Closes: sosreport#795, sosreport#826.

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
TurboTurtle pushed a commit to TurboTurtle/sos that referenced this issue Jul 13, 2016
crm_report should be called with --sos-mode option for preffered
collection of log files.

Closes: sosreport#795, sosreport#826.

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
poornimakshirsagar pushed a commit to poornimakshirsagar/sos that referenced this issue Jan 5, 2017
crm_report should be called with --sos-mode option for preffered
collection of log files.

Closes: sosreport#795, sosreport#826.

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
karibou pushed a commit to karibou/sosreport that referenced this issue Nov 16, 2017
crm_report should be called with --sos-mode option for preffered
collection of log files.

Closes: sosreport#795, sosreport#826.

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant