New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tailing gzipped logfiles should ungzip them first #907
Comments
Any fix has to deal with 2 problems:
Both might be resolved by using Very naive (and not working) patch (not relying on
|
I think it is simpler (and just as effective) to just say:
We already impose a considerable IO and CPU load on the collection host; I don't think we should add to that by slavishly decompressing, tailing, and recompressing data just to grab a snippet of log data. |
In case sizelimit in add_copy_spec is reached and tailit=True, we shall skip tailing a gzip archive that would be collected as damaged. Resolves: sosreport#907 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
In case sizelimit in add_copy_spec is reached and tailit=True, we shall skip tailing a gzip archive that would be collected as damaged. Resolves: sosreport#907 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
In case sizelimit in add_copy_spec is reached and tailit=True, we shall skip tailing a gzip archive that would be collected as damaged. Resolves: sosreport#907 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Having logfiles to collect with a limit, the latest/oldest file is truncated / only its tail is collected.
If this "border logfile" is gzip file,
sosreport
collectstail
of gzip archive, i.e. useless sequence of bytes.Reproducer:
The text was updated successfully, but these errors were encountered: