New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[azure] Added instance metadata and curl to RHUI if on demand image. #1145

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tanaka-takayoshi
Contributor

tanaka-takayoshi commented Nov 14, 2017

Instance metadat is useful to investigate the virtual machine
properties. We will find the base image, size, location and so on from
it. Also, connectivity to RHUI repo is required to work property for
Azure RHEL On-Demand image.

Signed-off-by: Takayoshi Tanaka tatanaka@redhat.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
@bmr-cymru

This comment has been minimized.

Member

bmr-cymru commented Nov 15, 2017

The curl commands all time out for me: to avoid creating delays for users who enable the plugin when it cannot retrieve these URLs please consider reducing the default timeout for these commands (e.g. to 5 or 10s each).

There is also trailing whitespace on the last line of the patch - please correct this and address the timeout problem (use git commit --amend or git rebase -i to edit the branch), and then you can update the pull request with git push --force.

@bmr-cymru

This comment has been minimized.

Member

bmr-cymru commented Nov 15, 2017

$ curl -s -vvv https://rhui-1.microsoft.com/pulp/repos/microsoft-azure-rhel7
*   Trying 52.174.163.213...
* TCP_NODELAY set
* connect to 52.174.163.213 port 443 failed: Connection timed out
* Failed to connect to rhui-1.microsoft.com port 443: Connection timed out
* Closing connection 0
@tanaka-takayoshi

This comment has been minimized.

Contributor

tanaka-takayoshi commented Nov 17, 2017

Thank you for checking. I'd like to add more command so I'll update this PR later including your advice.

@tanaka-takayoshi tanaka-takayoshi force-pushed the tanaka-takayoshi:azure branch from ed5c889 to cd93c1e Dec 7, 2017

@tanaka-takayoshi

This comment has been minimized.

Contributor

tanaka-takayoshi commented Dec 7, 2017

@bmr-cymru I updated the commit. Could you check it again?

@bmr-cymru

This comment has been minimized.

Member

bmr-cymru commented Apr 16, 2018

Please fix the formatting and whitespace errors mentioned previously so that we can get this patch merged:

$ pep8 sos
sos/plugins/azure.py:20:1: E302 expected 2 blank lines, found 1
sos/plugins/azure.py:38:80: E501 line too long (121 > 79 characters)
sos/plugins/azure.py:39:31: E127 continuation line over-indented for visual indent
sos/plugins/azure.py:41:1: E302 expected 2 blank lines, found 1
sos/plugins/azure.py:48:80: E501 line too long (98 > 79 characters)
sos/plugins/azure.py:49:80: E501 line too long (98 > 79 characters)
sos/plugins/azure.py:50:80: E501 line too long (97 > 79 characters)
sos/plugins/azure.py:55:80: E501 line too long (81 > 79 characters)
sos/plugins/azure.py:57:1: W293 blank line contains whitespace

@tanaka-takayoshi tanaka-takayoshi force-pushed the tanaka-takayoshi:azure branch from cd93c1e to aed1fc3 Apr 17, 2018

@tanaka-takayoshi

This comment has been minimized.

Contributor

tanaka-takayoshi commented Apr 17, 2018

@bmr-cymru I fixed the formatting and whitespace errors.

@tanaka-takayoshi tanaka-takayoshi force-pushed the tanaka-takayoshi:azure branch from aed1fc3 to a80850b Apr 17, 2018

[azure] Added instance metadata and curl to RHUI if on demand image.
Instance metadat is useful to investigate the virtual machine
properties. We will find the base image, size, location and so on from
it. Also, connectivity to RHUI repo is required to work property for
Azure RHEL On-Demand image.

We fixed the WALinuxAgent package name type to enable this plugin
by default when WALinuxAgent is running. It's usually running only on
Azure.

Signed-off-by: Takayoshi Tanaka <tatanaka@redhat.com>

@tanaka-takayoshi tanaka-takayoshi force-pushed the tanaka-takayoshi:azure branch from a80850b to 088ed11 Apr 17, 2018

@bmr-cymru

This comment has been minimized.

Member

bmr-cymru commented Apr 17, 2018

Thanks! I'll get this merged soon.

@bmr-cymru bmr-cymru closed this in ca755c2 Apr 17, 2018

igoihman added a commit to igoihman/sos that referenced this pull request Jul 23, 2018

[azure] Added instance metadata and curl to RHUI if on demand image.
Instance metadat is useful to investigate the virtual machine
properties. We will find the base image, size, location and so on from
it. Also, connectivity to RHUI repo is required to work property for
Azure RHEL On-Demand image.

We fixed the WALinuxAgent package name type to enable this plugin
by default when WALinuxAgent is running. It's usually running only on
Azure.

Resolves: sosreport#1145

Signed-off-by: Takayoshi Tanaka <tatanaka@redhat.com>
Signed-off-by: Bryn M. Reeves <bmr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment