Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dnf] Collect module --list and use collect_cmd_output content #1887

Closed
wants to merge 2 commits into from

Conversation

TurboTurtle
Copy link
Member

This is a 2-patch set that:

  1. Updates dnf to use the output key of the collect_cmd_output() dict instead of re-reading the file into memory.
  2. Adds dnf module list to collection, not just dnf module list --installed as requested in RHBZ#1781819

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • If this commit closes an existing issue, is the line Closes: #ISSUENUMBER included in an independent line?
  • If this commit resolves an existing pull request, is the line Resolves: #PRNUMBER included in an independent line?

As the installed module loop uses `collect_cmd_output`, we can just
iterate over the output directly, rather than re-reading the contents
into memory a second time via the saved file.

Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Adds collection of `dnf module list` to the plugin, to show a list of
all modules available to the system, instead of just those that are
currently installed.

Related: RHBZ#1781819
Resolves: sosreport#1887

Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
@pmoravec pmoravec closed this in 703c966 Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants