[nfs] merge nfsserver plugin into nfs one #2073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cc @pierg75 for review and @BryanQuigley for Nfs plugin extension on Ubuntu/Debian - wont these extra files/dirs and commands harm? |
|
Looks good to me. Thanks! |
TurboTurtle
reviewed
May 18, 2020
sos/report/plugins/nfs.py
Outdated
| @@ -14,7 +14,7 @@ class Nfs(Plugin, RedHatPlugin, DebianPlugin, UbuntuPlugin): | |||
| short_desc = 'Network file system information' | |||
| plugin_name = 'nfs' | |||
| profiles = ('storage', 'network', 'nfs') | |||
| packages = ['nfs-utils'] | |||
| packages = ('nfs-utils') | |||
nfsserver plugin enabledness relies on legacy init scripts. A more appropriate way to idenfity a NFS server is via nfs-utils package (though it could be present also on a NFS client). As that package enables nfs plugin, it is reasonable to merge the plugins into one. Resolves: sosreport#2061 Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
pmoravec
force-pushed
the
sos-pmoravec-nfsserver-enable
branch
from
d2785b9
to
96695d8
Compare
|
Ah, I see, fixed. |
TurboTurtle
approved these changes
May 19, 2020
jjansky1
added a commit
to jjansky1/sos
that referenced
this pull request
May 19, 2020
nfsserver plugin enabledness relies on legacy init scripts. A more appropriate way to idenfity a NFS server is via nfs-utils package (though it could be present also on a NFS client). As that package enables nfs plugin, it is reasonable to merge the plugins into one. Related: sosreport#2073 Resolves: sosreport#2076 Closes: sosreport#2061 Signed-off-by: Jan Jansky <jjansky@redhat.com>
6 tasks
TurboTurtle
pushed a commit
that referenced
this pull request
May 20, 2020
nfsserver plugin enabledness relies on legacy init scripts. A more appropriate way to idenfity a NFS server is via nfs-utils package (though it could be present also on a NFS client). As that package enables nfs plugin, it is reasonable to merge the plugins into one. Related: #2073 Resolves: #2076 Closes: #2061 Signed-off-by: Jan Jansky <jjansky@redhat.com> Signed-off-by: Jake Hunsaker <jhunsake@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nfsserver plugin enabledness relies on legacy init scripts. A more
appropriate way to idenfity a NFS server is via nfs-utils package
(though it could be present also on a NFS client).
As that package enables nfs plugin, it is reasonable to merge the
plugins into one.
Resolves: #2061
Signed-off-by: Pavel Moravec pmoravec@redhat.com
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines
Closes: #ISSUENUMBERincluded in an independent line?Resolves: #PRNUMBERincluded in an independent line?