Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MigrationResults] collect info about conversions and upgrades #2631

Merged

Conversation

bvassova
Copy link
Contributor

A new tiny plugin independent on leapp and convert2rhel is proposed.

It should collect /etc/migration-results with info about RHEL
conversions and upgrades, whenever the file is present.

Resolves: #2631
Related: #2627
Relevant to: rhbz#1959598

Signed-off-by: Barbora Vassova bvassova@redhat.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?


class MigrationResults(Plugin, RedHatPlugin):

short_desc = 'Information about conversions and upgrades'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be in the

"""Information about conversions and upgrades"""

comment style - compare it with other plugins. short_desc works well since 4.0, until then you get:

# sosreport -l

..
The following plugins are currently disabled:

..
 memcached            inactive       memcached distributed memory caching system
 migration_results    inactive       This is the base class for sosreport plugins. Plugins should subclass
    this and set the class variables where applicable.

    plugin_name is a string returned by plugin.name(). If this is set to None
    (the default) class\_.__name__.tolower() will be returned. Be sure to set
    ..
 mongodb              inactive       MongoDB document database

A new tiny plugin independent on leapp and convert2rhel is proposed.

It should collect /etc/migration-results with info about RHEL
conversions and upgrades, whenever the file is present.

Resolves: sosreport#2631
Related: sosreport#2627
Relevant to: rhbz#1959598

Signed-off-by: Barbora Vassova <bvassova@redhat.com>
@bvassova bvassova force-pushed the legacy-3.9-migrationresults branch from 5b94f1c to 19817b1 Compare July 28, 2021 08:50
@TurboTurtle TurboTurtle merged commit 92ddbb8 into sosreport:legacy-3.9 Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants