Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[foreman] Collect puma status and stats #2712

Merged

Conversation

pmoravec
Copy link
Contributor

@pmoravec pmoravec commented Oct 4, 2021

Collect foreman-puma-status and 'pumactl [gc-|]stats', optionally using
SCL (if detected).

Resolves: #2712

Signed-off-by: Pavel Moravec pmoravec@redhat.com


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

Collect foreman-puma-status and 'pumactl [gc-|]stats', optionally using
SCL (if detected).

Resolves: sosreport#2712

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
# if we are on RHEL7 with scl, wrap some Puma commands by
# scl enable tfm 'command'
if self.policy.dist_version() == 7 and is_executable('scl'):
self.pumactl = "scl enable tfm '%s'" % self.pumactl
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can utilise SCLPlugin.convert_cmd_scl method but:

  • we dont need to modify PATH here
  • it might be a bit overkill to use the class at all, if majority of (future) execution will not use SCL at all

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you already use foreman-puma-status (good!). If it's easier, we can probably introduce wrappers for other Puma things. I suspect other users may find them useful too.

@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

⚠️ Please note that our current plans include removal of these comments in the near future (at least 2 weeks after including this disclaimer), if you have serious concerns regarding their removal or would like to continue receiving them please reach out to us. ⚠️

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-2712
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle TurboTurtle merged commit 5a9458d into sosreport:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants