Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[virsh] Call virsh commands in the foreground / with a TTY #2825

Merged
merged 2 commits into from Jan 17, 2022
Merged

[virsh] Call virsh commands in the foreground / with a TTY #2825

merged 2 commits into from Jan 17, 2022

Conversation

pmoravec
Copy link
Contributor

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

@pmoravec
[report] pass foreground argument to collect_cmd_output
68e0426 
Related to: sosreport#2825

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@pmoravec
[virsh] Call virsh commands in the foreground / with a TTY
0650965 
In some virsh errors (like unable to connect to a hypervisor),
the tool requires to communicate to TTY otherwise it can get stuck
(when called via Popen with a timeout).

Calling it on foreground prevents the stuck / waiting on cmd timeout.

Resolves: sosreport#2825

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
@pmoravec pmoravec changed the title Sos pmoravec virsh foreground [virsh] Call virsh commands in the foreground / with a TTY Jan 14, 2022
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-2825
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@TurboTurtle TurboTurtle merged commit 747fef6 into sosreport:main Jan 17, 2022
TurboTurtle pushed a commit that referenced this pull request Jan 17, 2022
@pmoravec @TurboTurtle
[report] pass foreground argument to collect_cmd_output
137abd3 
Related to: #2825

Signed-off-by: Pavel Moravec <pmoravec@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TurboTurtle TurboTurtle TurboTurtle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pmoravec @TurboTurtle