[report] Prevent obfuscating tmpDir path before tarbal move

[pmoravec]

When moving sos tarball from a private directory to /var/tmp, apply filename obfuscation just to the file and not the tmpDir path itself.

Resolves: #3065

Signed-off-by: Pavel Moravec pmoravec@redhat.com

---

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

• Is the commit message split over multiple lines and hard-wrapped at 72 characters?
• Is the subject and message clear and concise?
• Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
• Does the commit contain a Signed-off-by: First Lastname email@example.com?
• Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

[pmoravec]

Reproducer:

python3 bin/sos report --clean --keywords tmp -o system,host --batch --disable-parsers=ip,mac,username
..
Error moving archive file: /var/tmp/sos.rmyfph6e/sosreport-host0-2022-11-13-lkvrnxp.tar.xz

The reason is final_name = cleaner.obfuscate_string(... is applied to full name including the /var/tmp path.

Here it is bit artificial reproducer, but when ones uses custom --tmp-dir to a sensitive location, it becomes a real issue.

[packit-as-a-service]

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

• sudo yum install -y dnf-plugins-core on RHEL 8
• sudo dnf install -y dnf-plugins-core on Fedora
• dnf copr enable packit/sosreport-sos-3065
• And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

[TurboTurtle]

Ack, nice catch.