Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zvm] Don't require 'vmcp' and 'cpint' kernel modules #3238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rmetrich
Copy link
Contributor

These modules are not present anymore, at least on RHEL8. The modules are not needed to execute 'vmcp' commands.


Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname email@example.com?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?

These modules are not present anymore, at least on RHEL8.
The modules are not needed to execute 'vmcp' commands.

Signed-off-by: Renaud Métrich <rmetrich@redhat.com>
@packit-as-a-service
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3238
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin is currently written to be distro-agnostic, so I'd like to either get a confirmation that these kernel modules are not used on other distributions or we'd need to split up the plugin to be distribution sensitive again.

Alternatively, if RHEL (and derivatives) are the only supported OS(es) for Z environments, then we can take this change as is (and ideally should replace IndependentPlugin with RedHatPlugin).

I'd just like to be 100% sure before merging.

@pmoravec
Copy link
Contributor

If I understood https://www.ibm.com/docs/en/linux-on-systems?topic=c-vmcp properly, then vmcp kmod is available on (some) RHEL8.6, still.

@rmetrich , you say there are systems with no vmcp or cpinit kmod (even available), where either vmcp or hcp command works?

If so, maybe an idea of improvement of kmod predicate that would help here: have a list of all kmods available on the system, and apply the predicate to intersection of the list and kmods list (i.e. apply the kmods list to available kmods only).

@rmetrich
Copy link
Contributor Author

If I understood https://www.ibm.com/docs/en/linux-on-systems?topic=c-vmcp properly, then vmcp kmod is available on (some) RHEL8.6, still.

@rmetrich , you say there are systems with no vmcp or cpinit kmod (even available), where either vmcp or hcp command works?

If so, maybe an idea of improvement of kmod predicate that would help here: have a list of all kmods available on the system, and apply the predicate to intersection of the list and kmods list (i.e. apply the kmods list to available kmods only).

I don't know, all I did is install a s390x KVM and tried to execute "modprobe vmcp" and there was no such module.
Then commenting out the predicate, I could see "vmcp" commands were just working fine anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants