[foreman] Skip collection of generic resources #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New option was added to foreman-debug (-g) to skip collecting of generic resources (firewall, selinux, cpu, memory). This patch leverages that. https://github.com/theforeman/foreman/blob/develop/script/foreman-debug Since katello-debug is now part of foreman-debug (as a plugin), there is no need of separate sosreport plugin. https://github.com/Katello/katello/blob/master/deploy/script/katello-debug.sh New subpackage called foreman-debug was introduced. It is present in both upstream Foreman and Katello installations as well as on both Satellite 6 main node and capsule instances. It can be used to detect if foreman-debug script is present. Signed-off-by: Lukas Zapletal <lzap+git@redhat.com>
|
Our upstream bug is: http://projects.theforeman.org/issues/8710 Downstream bug is: https://bugzilla.redhat.com/show_bug.cgi?id=1134109 This also solves the two dependant bugs we commented today. Ideally we should wait until everything is merged. If you want, I can ping you when appropriate. But I don't expect changes in this field. Thanks for help! |
|
Since it's upstream (and won't be in a release for some time) I'm happy to merge it now - anyone who's running master should expect some turbulence or dependencies on unreleased changes :) Thanks for working on this! |
|
Roger wilco. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New option was added to foreman-debug (-g) to skip collecting of generic
resources (firewall, selinux, cpu, memory). This patch leverages that.
https://github.com/theforeman/foreman/blob/develop/script/foreman-debug
Since katello-debug is now part of foreman-debug (as a plugin), there is no
need of separate sosreport plugin.
https://github.com/Katello/katello/blob/master/deploy/script/katello-debug.sh
New subpackage called foreman-debug was introduced. It is present in both
upstream Foreman and Katello installations as well as on both Satellite 6 main
node and capsule instances. It can be used to detect if foreman-debug script
is present.
Signed-off-by: Lukas Zapletal lzap+git@redhat.com