Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable the browser displaying the standard context menu #52

Closed
sothawo opened this issue Apr 27, 2019 · 6 comments

Comments

@sothawo
Copy link
Owner

commented Apr 27, 2019

the implemente dway to disable the default browser context menu on the map is not working anymore (not sure since which version). Must investigate and fix.

@sothawo sothawo added the bug label Apr 27, 2019

@sothawo sothawo self-assigned this Apr 27, 2019

@sothawo sothawo added this to To do in mapjfx Apr 27, 2019

@myrage2000

This comment has been minimized.

Copy link

commented May 23, 2019

Hi, this would be great !
Have you looked at setContextMenuEnabled ?

@sothawo

This comment has been minimized.

Copy link
Owner Author

commented May 23, 2019

@myrage2000 I know this exists, but then this disables the contect menu on the markers and labels as well. I have Javascript code in the page which should (and used) to intercept the context menu, but this is not working anymore. Not sure when the Webkit browser changed here, because that used to work.

@trixon

This comment has been minimized.

Copy link

commented Aug 8, 2019

@sothawo Would it be possible to let one choose to disable the context menu for the markers too, at least for now?

Every time I press the right mouse button, I get a new "page" below the previous ones and the scrollbar appears. After that the map stops loading new tiles.

Is that related somehow?

@sothawo

This comment has been minimized.

Copy link
Owner Author

commented Aug 8, 2019

yes, that's the same problem, it really is a nuisance; the code to disbale the contextmenu on the map (not the markers for example) which I have still works, if the page is viewed with a normal browser. It's the WebView that must have changed something.
I think it should be possible to deactivate the whole contextmenu stuff like @myrage2000 proposed, and this could be done by adding a correspondig setting to the MapView class.

I'll add this to my todo's for the next days.

Although I'd prefer to get it working like it used to be.

@sothawo sothawo moved this from To do to In progress in mapjfx Aug 9, 2019

@sothawo

This comment has been minimized.

Copy link
Owner Author

commented Aug 9, 2019

I found the regression; some error on my side in the last changes. I have it fixed locally, will release the fixed versions today or tomorrow

@sothawo sothawo moved this from In progress to Done in mapjfx Aug 9, 2019

@sothawo

This comment has been minimized.

Copy link
Owner Author

commented Aug 9, 2019

fixed in 2.7.3 and 1.26.3

@sothawo sothawo closed this Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.