New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top margin option. Set options to wrap text. Fix doc. #21

Merged
merged 5 commits into from Nov 17, 2016

Conversation

Projects
None yet
2 participants
@PhilRunninger
Contributor

PhilRunninger commented Nov 14, 2016

The changes are pretty well documented in the commit messages. In summary:

  • Updated the documentation to remove obsolete reference to dictionary
  • Fixed formatting of the plugin's name in the help doc.
  • Added an option to insert a specified number of blank lines above each slide.
  • Appended blank lines after each slide to push the ~ lines off the window.
  • Set 4 vim options to enable wrapping of text.

Phil Runninger added some commits Nov 14, 2016

Phil Runninger
Add option for top margin size. Pad the bottom to hide tildes.
* The specified number (default = 0) of blank lines is inserted above
each slide as they are shown.
* A calculated number of blank lines is appended below each slide to
force the ~ lines off the bottom of the window.
Phil Runninger
Set options to wrap text cleanly, and turn of the list option.
Text is wrapped (set wrap) at word boundaries (set linebreak), and
indented (set breakindent) to the same level as the previous line.
Phil Runninger
Move to top of slide before padding the bottom of it.
To calculate the number of blank lines required for the bottom margin,
the slide needs to be scrolled all the way to the top.
@sotte

This comment has been minimized.

Show comment
Hide comment
@sotte

sotte Nov 16, 2016

Owner

Thanks for the contributions!

Also, can you add an example in the examples/ folder which demonstrates the feature. You can use vim's modeline to set the presenting_top_margin.

Now that I'm thinking about it I'm wondering if "add top margins" is really what we want, or if it's rather a "center vertically" feature. What do you think?

Owner

sotte commented Nov 16, 2016

Thanks for the contributions!

Also, can you add an example in the examples/ folder which demonstrates the feature. You can use vim's modeline to set the presenting_top_margin.

Now that I'm thinking about it I'm wondering if "add top margins" is really what we want, or if it's rather a "center vertically" feature. What do you think?

@PhilRunninger

This comment has been minimized.

Show comment
Hide comment
@PhilRunninger

PhilRunninger Nov 16, 2016

Contributor

Regarding the example, I may be missing something, but isn't the modeline used to set options, not variables? Vim is complaining that presenting_top_margin is an unknown option.

<!--
vim:tw=40:ft=markdown:presenting_top_margin=5
-->

Centering vertically could be challenging if lines start wrapping. We can count the lines of text in the array and make a calculation that way, but if a line displays on more than one, the text will be too low on the screen. Personally, I like seeing the slides with a consistent top margin, à la Powerpoint.

Contributor

PhilRunninger commented Nov 16, 2016

Regarding the example, I may be missing something, but isn't the modeline used to set options, not variables? Vim is complaining that presenting_top_margin is an unknown option.

<!--
vim:tw=40:ft=markdown:presenting_top_margin=5
-->

Centering vertically could be challenging if lines start wrapping. We can count the lines of text in the array and make a calculation that way, but if a line displays on more than one, the text will be too low on the screen. Personally, I like seeing the slides with a consistent top margin, à la Powerpoint.

@sotte

This comment has been minimized.

Show comment
Hide comment
@sotte

sotte Nov 17, 2016

Owner

Hey Phil,

you're totally right about the modeline and variables. For whatever reason I thought you can do it. So no example file needed.

Centering vertically: maybe it's too much trouble. I'll merge it and we can change it later (if someone want to do that :)).

Thanks for the contributions!

Owner

sotte commented Nov 17, 2016

Hey Phil,

you're totally right about the modeline and variables. For whatever reason I thought you can do it. So no example file needed.

Centering vertically: maybe it's too much trouble. I'll merge it and we can change it later (if someone want to do that :)).

Thanks for the contributions!

@sotte sotte closed this Nov 17, 2016

@sotte sotte merged commit 01351aa into sotte:master Nov 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment