New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Bit2c exchange #1

Merged
merged 3 commits into from Apr 7, 2014

Conversation

Projects
None yet
2 participants
@erezwanderman
Contributor

erezwanderman commented Feb 22, 2014

I'll ask Bit2c to add a read-only option to their API to make it "safe".

@soundasleep

This comment has been minimized.

Show comment
Hide comment
@soundasleep

soundasleep Mar 21, 2014

Should have a link through to "only available through an unsafe instance" (as per Cryptsy above).

soundasleep commented on templates/inline_add_service.php in e3a2be7 Mar 21, 2014

Should have a link through to "only available through an unsafe instance" (as per Cryptsy above).

@soundasleep

This comment has been minimized.

Show comment
Hide comment
@soundasleep

soundasleep Mar 21, 2014

This needs to be in the if get_site_config('allow_unsafe') section of batch_run, so that if unsafe is disabled, then the account can't be executed.

soundasleep commented on batch_run.php in e3a2be7 Mar 21, 2014

This needs to be in the if get_site_config('allow_unsafe') section of batch_run, so that if unsafe is disabled, then the account can't be executed.

@soundasleep

This comment has been minimized.

Show comment
Hide comment
@soundasleep

soundasleep Mar 21, 2014

This needs to be in the if get_site_config('allow_unsafe') section of batch_queue, so that if unsafe is disabled, then we aren't looking for unsafe tables that might not exist and crash.

soundasleep commented on batch_queue.php in e3a2be7 Mar 21, 2014

This needs to be in the if get_site_config('allow_unsafe') section of batch_queue, so that if unsafe is disabled, then we aren't looking for unsafe tables that might not exist and crash.

@soundasleep

This comment has been minimized.

Show comment
Hide comment
@soundasleep

soundasleep Mar 21, 2014

Owner

This is generally excellent, there are a few sections where unsafe code needs to be wrapped with checks. I've left some comments on the commit.

(I don't currently have access to the git svn bridge otherwise I would fix these issues right now myself.)

Owner

soundasleep commented Mar 21, 2014

This is generally excellent, there are a few sections where unsafe code needs to be wrapped with checks. I've left some comments on the commit.

(I don't currently have access to the git svn bridge otherwise I would fix these issues right now myself.)

@erezwanderman

This comment has been minimized.

Show comment
Hide comment
@erezwanderman

erezwanderman Mar 24, 2014

Contributor

Changed the code, not sure if that's what I was supposed to do (and don't know anything about git svn bridge).
Please have a look.

Contributor

erezwanderman commented Mar 24, 2014

Changed the code, not sure if that's what I was supposed to do (and don't know anything about git svn bridge).
Please have a look.

@erezwanderman

This comment has been minimized.

Show comment
Hide comment
@erezwanderman

erezwanderman Mar 25, 2014

Contributor

Good news: Bit2c updated their API so that when "Enable POST" is unchecked, the key becomes read only, "MyOrders" command will work but commands that do changes like cancel order will not.
I'll update the pull request with new commit soon.

Contributor

erezwanderman commented Mar 25, 2014

Good news: Bit2c updated their API so that when "Enable POST" is unchecked, the key becomes read only, "MyOrders" command will work but commands that do changes like cancel order will not.
I'll update the pull request with new commit soon.

@erezwanderman

This comment has been minimized.

Show comment
Hide comment
@erezwanderman

erezwanderman Mar 25, 2014

Contributor

Done. Now bit2c API is no longer unsafe.

Contributor

erezwanderman commented Mar 25, 2014

Done. Now bit2c API is no longer unsafe.

@erezwanderman

This comment has been minimized.

Show comment
Hide comment
@erezwanderman

erezwanderman Apr 5, 2014

Contributor

hey @soundasleep, are you going to pull this?

Contributor

erezwanderman commented Apr 5, 2014

hey @soundasleep, are you going to pull this?

@soundasleep

This comment has been minimized.

Show comment
Hide comment
@soundasleep

soundasleep Apr 6, 2014

Owner

Yes - just waiting until I have the time to merge and test this before release (which should be tomorrow in fact). The code looks really good.

Owner

soundasleep commented Apr 6, 2014

Yes - just waiting until I have the time to merge and test this before release (which should be tomorrow in fact). The code looks really good.

@soundasleep soundasleep merged commit f83e656 into soundasleep:master Apr 7, 2014

@soundasleep

This comment has been minimized.

Show comment
Hide comment
@soundasleep

soundasleep Apr 7, 2014

Owner

Had to get my head around git rebases since master had changed, but I think it's now merged as of SVN r966. Will be deploying later today. Thanks for the PR and your patience :)

Owner

soundasleep commented Apr 7, 2014

Had to get my head around git rebases since master had changed, but I think it's now merged as of SVN r966. Will be deploying later today. Thanks for the PR and your patience :)

@soundasleep

This comment has been minimized.

Show comment
Hide comment
@soundasleep
Owner

soundasleep commented Apr 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment