Option to not use syslog header #1

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants

I'm going to flip out if I have to see log-lines wrap any more.

@cloudhead cloudhead Option to not use syslog header
I'm going to flip out if I have to see log-lines wrap
any more.
513910e
Contributor

tsenart commented Jul 5, 2012

Where are the tests?

@tsenart the tests for the syslog format pass - the non-syslog format doesn't need to be reliable, or relied upon.

kim commented Jul 5, 2012

ahem, there is no actual contract to use all of those field in the header. the really useful one is x-category, if one wants a dedicated bucket. also, swVersion could be useful, as well as the request (or: correlation) id -- in theory.

Contributor

tsenart commented Jul 5, 2012

@cloudhead I don't understand. If it doesn't need to be relied upon then why are you requesting this code to be merged?

Owner

streadway commented Jul 5, 2012

From a public interface point of view for a shared library - leaking the internal representation up as a boolean on the log structure seems like it will be an interface design that will eventually lead us to an array of booleans to fiddle with the internal bits. If you want to control this, rather add a formatter interface than expose the implementation via booleans.

If this is merely cosmetic for debugging, then pipe your results through sed and strip the syslog headers how you'd like.

👎

Can't be bothered to implement a formatter interface - I'll just fork the project for local use.

@tsenart: it's for development use.

cloudhead closed this Jul 5, 2012

xla deleted the feature/optional-syslog-header branch Sep 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment