From 5f6681f2c689cd7e9bc5c70d51c915615f552959 Mon Sep 17 00:00:00 2001 From: Scala Steward Date: Thu, 14 Sep 2023 03:32:30 +0000 Subject: [PATCH 1/3] Update scala-library to 2.13.12 --- build.sbt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.sbt b/build.sbt index 8ac9ac1..edafc58 100644 --- a/build.sbt +++ b/build.sbt @@ -1,5 +1,5 @@ lazy val scala212 = "2.12.18" -lazy val scala213 = "2.13.7" +lazy val scala213 = "2.13.12" lazy val commonSettings = List( scalaVersion := scala212, From 1084430e4a0775923a8a30206b631e75b4f6dabb Mon Sep 17 00:00:00 2001 From: Christopher Taylor Date: Fri, 9 Feb 2024 15:40:46 +0100 Subject: [PATCH 2/3] add required type hint --- runtime/src/main/scala/com/soundcloud/twinagle/JsonError.scala | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/runtime/src/main/scala/com/soundcloud/twinagle/JsonError.scala b/runtime/src/main/scala/com/soundcloud/twinagle/JsonError.scala index ace57d0..54ad2dc 100644 --- a/runtime/src/main/scala/com/soundcloud/twinagle/JsonError.scala +++ b/runtime/src/main/scala/com/soundcloud/twinagle/JsonError.scala @@ -19,7 +19,7 @@ private[twinagle] object JsonError { import org.json4s.native.Serialization.{read, write} import scala.util.control.Exception._ - implicit val formats = Serialization.formats(NoTypeHints) + implicit val formats: Formats = Serialization.formats(NoTypeHints) def fromString(str: String): Option[JsonError] = allCatch opt { read[JsonError](str) From fc1c4e31238c09171adc3017116699aeff1e4be1 Mon Sep 17 00:00:00 2001 From: Christopher Taylor Date: Fri, 9 Feb 2024 15:59:15 +0100 Subject: [PATCH 3/3] disable unnecessary warnings it's fine that some of the "must not throw(...)" expressions don't produce useful values --- .../com/soundcloud/twinagle/ClientEndpointBuilderSpec.scala | 3 +++ 1 file changed, 3 insertions(+) diff --git a/runtime/src/test/scala/com/soundcloud/twinagle/ClientEndpointBuilderSpec.scala b/runtime/src/test/scala/com/soundcloud/twinagle/ClientEndpointBuilderSpec.scala index d197050..55d9efb 100644 --- a/runtime/src/test/scala/com/soundcloud/twinagle/ClientEndpointBuilderSpec.scala +++ b/runtime/src/test/scala/com/soundcloud/twinagle/ClientEndpointBuilderSpec.scala @@ -5,6 +5,9 @@ import com.twitter.finagle.{Filter, Service} import com.twitter.finagle.http.{Request, Response} import org.specs2.mutable.Specification +import scala.annotation.nowarn + +@nowarn("cat=lint-infer-any") class ClientEndpointBuilderSpec extends Specification { val httpClient: Service[Request, Response] =