Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proton Compatibility #2

Closed
6 tasks done
soup-bowl opened this issue May 16, 2021 · 1 comment
Closed
6 tasks done

Proton Compatibility #2

soup-bowl opened this issue May 16, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@soup-bowl
Copy link
Owner

soup-bowl commented May 16, 2021

Split into two segments, one with the problems that can be seen with browser.proton.enabled, and ones visible regardless. Latter is the priority for achieving MVP.

Changes are tracked in Photon branch (aware the name is wrong).

Constant.

  • Misplacement of Tabs bar.
  • New element on bookmarks bar causes distortion.

Proton-related (aka, disappear when browser.proton.enabled is on).

  • Tab size exceeded tab bar.
  • (technically without) Back button is sized inconsistently.
  • URL bar elements break out of their confines.
  • Missing icons in the Application Menu (might've been a Nightly bug).
@soup-bowl soup-bowl added the enhancement New feature or request label May 16, 2021
@soup-bowl soup-bowl self-assigned this May 16, 2021
@soup-bowl soup-bowl pinned this issue May 16, 2021
@soup-bowl soup-bowl mentioned this issue May 16, 2021
7 tasks
@soup-bowl soup-bowl changed the title Proton Compatibility Photon Compatibility May 16, 2021
@soup-bowl soup-bowl changed the title Photon Compatibility Proton Compatibility May 16, 2021
@soup-bowl
Copy link
Owner Author

The even-sized UI button conditions for pre-proton Normal and Touch densities have been removed, as I was unable to get them to work correctly with Proton conditions. I tried a various different medley of conditions using uidensity and proton, but nothing seemed to work without the Proton. Since this will take over, I've removed it in favour of Proton, since Compact still works fine.

@soup-bowl soup-bowl unpinned this issue May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant