From 01595589914c68822851412cb66a0e0f1e44c47e Mon Sep 17 00:00:00 2001
From: Richard Dominick <34370238+RichDom2185@users.noreply.github.com>
Date: Fri, 4 Oct 2024 20:21:01 +0800
Subject: [PATCH] fix: Wrong effective ID in unpublish notifications

---
 lib/cadet/assessments/assessments.ex | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/cadet/assessments/assessments.ex b/lib/cadet/assessments/assessments.ex
index 500d6c776..d6ca6b362 100644
--- a/lib/cadet/assessments/assessments.ex
+++ b/lib/cadet/assessments/assessments.ex
@@ -1250,9 +1250,17 @@ defmodule Cadet.Assessments do
         |> Submission.changeset(%{is_grading_published: false})
         |> Repo.update()
 
+        # assumption: if team assessment, all team members are under the same avenger
+        effective_student_id =
+          if is_nil(submission.student_id) do
+            Teams.get_first_member(submission.team_id).student_id
+          else
+            submission.student_id
+          end
+
         Notifications.handle_unpublish_grades_notifications(
           submission.assessment.id,
-          Repo.get(CourseRegistration, submission.student_id)
+          Repo.get(CourseRegistration, effective_student_id)
         )
 
         {:ok, nil}