Add maxGrade in UserInfo for submitted submissions #206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1487
💛 - Coveralls |
ning-y
approved these changes
Aug 13, 2018
Member
ning-y
left a comment
ning-y
left a comment
There was a problem hiding this comment.
As usual, specs looks good, but can't comment on the code.
tuesmiddt
requested changes
Aug 13, 2018
Contributor
tuesmiddt
left a comment
tuesmiddt
left a comment
There was a problem hiding this comment.
Minor issue with the query.
lib/cadet/assessments/assessments.ex
Outdated
| Submission | ||
| |> where(status: ^:submitted) | ||
| |> join(:inner, [s], student in assoc(s, :student)) | ||
| |> where([_, student], student.id == ^user_id) |
Contributor
There was a problem hiding this comment.
No need for this. Submission has student_id field.
| def user_max_grade(%User{id: user_id}) when is_ecto_id(user_id) do | ||
| max_grade = | ||
| Submission | ||
| |> where(status: ^:submitted) |
Contributor
There was a problem hiding this comment.
This is cool. Didn't know you could do that.
indocomsoft
force-pushed
the
user-max-grade
branch
from
1477e7a to
24a7ff6
Compare
indocomsoft
added a commit
that referenced
this pull request
Aug 17, 2018
* Add maxGrade in UserInfo for submitted submissions * Address code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #205