Skip to content

Add Total XP Calculation #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Apr 23, 2022
Merged

Add Total XP Calculation #859

merged 26 commits into from
Apr 23, 2022

Conversation

@ShenyiCui
Copy link
Contributor

@ShenyiCui ShenyiCui commented Mar 1, 2022

Changes

  • New Incentive Controller function calculate_totalxp()
  • New Achievement function get_total_xp()
  • Calling the API endpoint calculate_totalxp will return a value denoting the current total XP for the current user.

Testing

  • Navigate to dev.exs and provide your local database credentials
  • Open API link: Postman Testing
  • Retrieve an authorisation token
  • Set your course_id
  • Run the API call Get Total XP

Expected Result
Screenshot 2022-03-02 at 1 02 32 AM

@ShenyiCui ShenyiCui added Enhancement New feature or request _API labels Mar 1, 2022
@ShenyiCui ShenyiCui requested a review from boydanderson March 1, 2022 17:04
angelsl
angelsl requested changes Mar 1, 2022
View reviewed changes
ShenyiCui and others added 5 commits March 9, 2022 01:20
@ShenyiCui
Fix Bugs
cff2949 
- xp calc based on user_id
- xp calc based on goal count
@ShenyiCui
Refactor Code
c8fbea6 
- run mix format
@riccqi
Code cleanup
ce58119 
- Inlined small functions
- Changed function naming related to calculating total xp
- Moved total_xp endpoint to user route
@riccqi
Update mix.lock
a81d266
@ShenyiCui
Fix total_xp query
ac0376e 
- Calculate total xp through a single query.
- Fix variable issues in user_controller
@ShenyiCui ShenyiCui requested a review from angelsl March 22, 2022 18:44
@coveralls
Copy link

coveralls commented Mar 23, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.03%) to 96.737% when pulling 839b45f on Add-Totalxp-Calculation into d4f733f on master.

@angelsl angelsl merged commit c02c9f2 into master Apr 23, 2022
@riccqi riccqi mentioned this pull request Sep 21, 2022
Merged
@RichDom2185 RichDom2185 deleted the Add-Totalxp-Calculation branch October 16, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@riccqi riccqi riccqi left review comments

@angelsl angelsl angelsl approved these changes

@boydanderson boydanderson Awaiting requested review from boydanderson

Assignees

@ShenyiCui ShenyiCui

@riccqi riccqi

Labels

_API Enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShenyiCui @coveralls @angelsl @riccqi