From b51299ec046f3617005b8645c7629a9b2006e3e6 Mon Sep 17 00:00:00 2001 From: YaleChen299 Date: Wed, 7 Sep 2022 18:36:43 +0800 Subject: [PATCH 1/2] add contest score job logging --- lib/cadet/assessments/assessments.ex | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/cadet/assessments/assessments.ex b/lib/cadet/assessments/assessments.ex index 914c87f1a..02a780e03 100644 --- a/lib/cadet/assessments/assessments.ex +++ b/lib/cadet/assessments/assessments.ex @@ -6,6 +6,8 @@ defmodule Cadet.Assessments do use Cadet, [:context, :display] import Ecto.Query + require Logger + alias Cadet.Accounts.{Notification, Notifications, User, CourseRegistration} alias Cadet.Assessments.{Answer, Assessment, Query, Question, Submission, SubmissionVotes} alias Cadet.Autograder.GradingJob @@ -995,10 +997,14 @@ defmodule Cadet.Assessments do def update_rolling_contest_leaderboards do # 115 = 2 hours - 5 minutes if Log.log_execution("update_rolling_contest_leaderboards", Timex.Duration.from_minutes(115)) do + Logger.info("Started update_rolling_contest_leaderboards") + voting_questions_to_update = fetch_active_voting_questions() voting_questions_to_update |> Enum.map(fn qn -> compute_relative_score(qn.id) end) + + Logger.info("Successfully update_rolling_contest_leaderboards") end end @@ -1016,11 +1022,15 @@ defmodule Cadet.Assessments do """ def update_final_contest_leaderboards do # 1435 = 24 hours - 5 minutes - if Log.log_execution("update_rolling_contest_leaderboards", Timex.Duration.from_minutes(1435)) do + if Log.log_execution("update_final_contest_leaderboards", Timex.Duration.from_minutes(1435)) do + Logger.info("Started update_final_contest_leaderboards") + voting_questions_to_update = fetch_voting_questions_due_yesterday() voting_questions_to_update |> Enum.map(fn qn -> compute_relative_score(qn.id) end) + + Logger.info("Successfully update_final_contest_leaderboards") end end From 492783e74a04507fa0946c6612233f89d017c4f6 Mon Sep 17 00:00:00 2001 From: YaleChen299 Date: Wed, 7 Sep 2022 22:27:18 +0800 Subject: [PATCH 2/2] fix credo --- lib/cadet/assessments/assessments.ex | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/cadet/assessments/assessments.ex b/lib/cadet/assessments/assessments.ex index 02a780e03..b50524d4b 100644 --- a/lib/cadet/assessments/assessments.ex +++ b/lib/cadet/assessments/assessments.ex @@ -1001,8 +1001,9 @@ defmodule Cadet.Assessments do voting_questions_to_update = fetch_active_voting_questions() - voting_questions_to_update - |> Enum.map(fn qn -> compute_relative_score(qn.id) end) + _ = + voting_questions_to_update + |> Enum.map(fn qn -> compute_relative_score(qn.id) end) Logger.info("Successfully update_rolling_contest_leaderboards") end @@ -1027,8 +1028,9 @@ defmodule Cadet.Assessments do voting_questions_to_update = fetch_voting_questions_due_yesterday() - voting_questions_to_update - |> Enum.map(fn qn -> compute_relative_score(qn.id) end) + _ = + voting_questions_to_update + |> Enum.map(fn qn -> compute_relative_score(qn.id) end) Logger.info("Successfully update_final_contest_leaderboards") end