Skip to content

Conversation

@ning-y
Copy link
Member

@ning-y ning-y commented Jun 23, 2018

  • Scrollbars would show up for MCQs even with no overflow for me. Fixed by setting overflow to auto instead of scroll.

- CSS class side-content-text height being set to 100% would cause it to overflow when the side-content-tab buttons were being rendered. Fixed by setting flex.

@ning-y ning-y requested a review from remo5000 June 23, 2018 07:08
Copy link
Contributor

@remo5000 remo5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I seem to not get the scrollbar...I guess this is the benefit of OS-diversity in a team 😄

@remo5000 remo5000 merged commit d2d1a1a into mcq-workspace Jun 23, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 80

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 30.176%

Totals Coverage Status
Change from base Build 69: 0.0%
Covered Lines: 1084
Relevant Lines: 3148

💛 - Coveralls

ning-y pushed a commit that referenced this pull request Jun 23, 2018
* Add question prop for workspace

Also made the questions in IAssessment more specific

* Add mock MCQ display for MCQQuestion

* Decouple editorValue from editorContainer

It must now be passed as a prop. The parent that spawns an
EditorContainer can take care of the value.

* Simplify WorkspaceProps

* Add MCQChooser

* Arrange content of MCQChooser

* Style components to look consistent

* Add mcq question to MCQChooser

* Add word wrapping

* Make buttons colored

* Move mcqChooser scss into workspace

* Format and add tests

* Fix some CSS issues (#131)

* Bump version 0.1.0 -> 0.1.1
@ning-y ning-y deleted the mcq-workspace-a branch July 2, 2018 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants