-
-
Notifications
You must be signed in to change notification settings - Fork 3
add a dehinter.font.dehint method for programs (such as FontBakery) that import dehinter as a dependency
#61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a dehinter.font.dehint method for programs (such as FontBakery) that import dehinter as a dependency
#61
Conversation
|
This pull request introduces 2 alerts when merging ab89b80 into 5bf40dd - view on LGTM.com new alerts:
|
ab89b80 to
e686528
Compare
|
This pull request introduces 1 alert when merging e686528 into 5bf40dd - view on LGTM.com new alerts:
|
e686528 to
2c9ad1e
Compare
|
@chrissimpkins This is good for being reviewed now, I think |
|
Thanks Felipe! Sorry, I didn't have PR CI support configured. Do you mind rebasing on 8c013cf and force pushing again to trigger the CI? |
|
ok, I'll do that now |
68ef6d7 to
ee8d9a7
Compare
|
why does it say "5 workflows awaiting approval"? Do you need to add me as an approved contributor in this repo? I've never seen this kind of "pending" status on PRs. |
|
I think it must be see something that GitHub put in place after the cryptomining shenanigans |
chrissimpkins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Felipe. Couple of requests and then we can merge this.
|
Is it helpful to expose the pre- / post-execution file size results? IIRC this was being tested by fontbakery. Do you have that covered FB side? |
Nvm. I see it in https://github.com/googlefonts/fontbakery/pull/3271/files#diff-bf950becbb6a50067f8e4b91219be2e719ab1ac47e3dbd429a24e63f54b8e9f0R309 |
… that import dehinter as a dependency
ee8d9a7 to
0f16186
Compare
|
It's ok to push new commits rather than squashing. It makes it easier to review the changes that you make to address the review. |
|
Thank you very much Felipe! I'll merge this and get a new release out tonight |
|
thanks! :-D |
|
Adding a new Thanks for adding this! |
No description provided.