From ecadb9629e1065e904fb3e6e4ca24d366e8450dd Mon Sep 17 00:00:00 2001 From: bkellam Date: Wed, 29 Oct 2025 13:35:28 -0700 Subject: [PATCH 1/5] Fix repos table image for repositories that don't have a image --- .../[domain]/repos/components/reposTable.tsx | 31 ++++++++++++------- 1 file changed, 19 insertions(+), 12 deletions(-) diff --git a/packages/web/src/app/[domain]/repos/components/reposTable.tsx b/packages/web/src/app/[domain]/repos/components/reposTable.tsx index 5074c3fd..c767acbc 100644 --- a/packages/web/src/app/[domain]/repos/components/reposTable.tsx +++ b/packages/web/src/app/[domain]/repos/components/reposTable.tsx @@ -14,7 +14,7 @@ import { Input } from "@/components/ui/input" import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from "@/components/ui/select" import { Table, TableBody, TableCell, TableHead, TableHeader, TableRow } from "@/components/ui/table" import { SINGLE_TENANT_ORG_DOMAIN } from "@/lib/constants" -import { CodeHostType, getCodeHostCommitUrl, getCodeHostInfoForRepo, getRepoImageSrc } from "@/lib/utils" +import { cn, CodeHostType, getCodeHostCommitUrl, getCodeHostIcon, getCodeHostInfoForRepo, getRepoImageSrc } from "@/lib/utils" import { type ColumnDef, type ColumnFiltersState, @@ -96,22 +96,29 @@ export const columns: ColumnDef[] = [ ) }, cell: ({ row }) => { - const repo = row.original + const repo = row.original; + const codeHostIcon = getCodeHostIcon(repo.codeHostType as CodeHostType); + const repoImageSrc = repo.imageUrl ? getRepoImageSrc(repo.imageUrl, repo.id) : undefined; + return (
- {repo.imageUrl ? ( - {`${repo.displayName} + ) : {`${repo.displayName} - ) : ( -
- {repo.displayName?.charAt(0) ?? repo.name.charAt(0)} -
- )} + } {/* Link to the details page (instead of browse) when the repo is indexing as the code will not be available yet */} @@ -124,7 +131,7 @@ export const columns: ColumnDef[] = [ })} className="font-medium hover:underline" > - {repo.displayName || repo.name} + {repo.displayName || repo.name} {repo.isFirstTimeIndex && ( From e50f0a2cd671393f01301d651d451579d976650a Mon Sep 17 00:00:00 2001 From: bkellam Date: Wed, 29 Oct 2025 13:42:23 -0700 Subject: [PATCH 2/5] add gerrit pattern for commit url --- packages/web/src/lib/utils.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/web/src/lib/utils.ts b/packages/web/src/lib/utils.ts index bc4850f0..783a1fc4 100644 --- a/packages/web/src/lib/utils.ts +++ b/packages/web/src/lib/utils.ts @@ -345,6 +345,7 @@ export const getCodeHostCommitUrl = ({ case 'bitbucket-server': return `${webUrl}/commits/${commitHash}`; case 'gerrit': + return `${webUrl}/+/${commitHash}`; case 'generic-git-host': return undefined; } @@ -376,7 +377,6 @@ export const getCodeHostBrowseAtBranchUrl = ({ return `${webUrl}?at=${branchName}`; case 'bitbucket-server': return `${webUrl}?at=${branchName}`; - case 'gerrit': case 'generic-git-host': return undefined; } From 79da94e5d80d62207e3aa340e15bf60e982985b8 Mon Sep 17 00:00:00 2001 From: bkellam Date: Wed, 29 Oct 2025 13:44:04 -0700 Subject: [PATCH 3/5] branch url --- packages/web/src/lib/utils.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/web/src/lib/utils.ts b/packages/web/src/lib/utils.ts index 783a1fc4..d3b450a0 100644 --- a/packages/web/src/lib/utils.ts +++ b/packages/web/src/lib/utils.ts @@ -377,6 +377,8 @@ export const getCodeHostBrowseAtBranchUrl = ({ return `${webUrl}?at=${branchName}`; case 'bitbucket-server': return `${webUrl}?at=${branchName}`; + case 'gerrit': + return `${webUrl}/+/${branchName}`; case 'generic-git-host': return undefined; } From 01d18694ba9493031494bd23d0c015df736e5ddd Mon Sep 17 00:00:00 2001 From: bkellam Date: Wed, 29 Oct 2025 13:49:14 -0700 Subject: [PATCH 4/5] fix ask homepage scrolling bug --- packages/web/src/app/[domain]/chat/[id]/page.tsx | 4 ++-- packages/web/src/app/[domain]/chat/layout.tsx | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/packages/web/src/app/[domain]/chat/[id]/page.tsx b/packages/web/src/app/[domain]/chat/[id]/page.tsx index 4929589b..24cd94e9 100644 --- a/packages/web/src/app/[domain]/chat/[id]/page.tsx +++ b/packages/web/src/app/[domain]/chat/[id]/page.tsx @@ -53,7 +53,7 @@ export default async function Page(props: PageProps) { const indexedRepos = repos.filter((repo) => repo.indexedAt !== undefined); return ( - <> +
- +
) } \ No newline at end of file diff --git a/packages/web/src/app/[domain]/chat/layout.tsx b/packages/web/src/app/[domain]/chat/layout.tsx index 2968c748..6f209420 100644 --- a/packages/web/src/app/[domain]/chat/layout.tsx +++ b/packages/web/src/app/[domain]/chat/layout.tsx @@ -14,9 +14,7 @@ export default async function Layout({ children }: LayoutProps) { // @note: we use a navigation guard here since we don't support resuming streams yet. // @see: https://ai-sdk.dev/docs/ai-sdk-ui/chatbot-message-persistence#resuming-ongoing-streams -
- {children} -
+ {children} ) From f48b69229ad9679ef3a361375d623e5fd209c6be Mon Sep 17 00:00:00 2001 From: bkellam Date: Wed, 29 Oct 2025 13:54:31 -0700 Subject: [PATCH 5/5] changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 52310b71..4a84b330 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +### Fixed +- Fixed commit and branch hyperlinks not rendering for Gerrit repos. [#581](https://github.com/sourcebot-dev/sourcebot/pull/581) +- Fixed visual bug when a repository does not have a image. [#581](https://github.com/sourcebot-dev/sourcebot/pull/581) +- Fixed issue where the Ask homepage was not scrollable. [#581](https://github.com/sourcebot-dev/sourcebot/pull/581) + ## [4.8.0] - 2025-10-28 ### Added