Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub plugin: Expose user addresses #1382

Merged
merged 1 commit into from Sep 18, 2019
Merged

GitHub plugin: Expose user addresses #1382

merged 1 commit into from Sep 18, 2019

Conversation

@decentralion
Copy link
Member

decentralion commented Sep 17, 2019

Allow getting the node address for a user, given the user's login. This
will be needed by the upcoming identity plugin.

If the login in question corresponds to a bot, then a bot address will
be returned. When we make the bot-set configuration (rather than
hardcoded), we'll need to change the signature of this function; I think
that's fine.

Test plan: Unit tests added. (Also, it's really simple.)

@decentralion decentralion requested review from Beanow and wchargin Sep 17, 2019
@@ -36,6 +37,24 @@ export const Prefix = deepFreeze({
pullComment: _githubAddress(COMMENT_TYPE, PULL_TYPE),
});

/**
* Return the address corresponding to a GitHub login.

This comment has been minimized.

Copy link
@wchargin

wchargin Sep 18, 2019

Member

GitHub logins can also correspond to organizations (they can correspond
to any Actor). Presumably we don’t care about those because we don’t
have nodes for organizations, but that probably merits at least a
comment?

This comment has been minimized.

Copy link
@decentralion

decentralion Sep 18, 2019

Author Member

Done.

Allow getting the node address for a user, given the user's login. This
will be needed by the upcoming identity plugin.

If the login in question corresponds to a bot, then a bot address will
be returned. When we make the bot-set configuration (rather than
hardcoded), we'll need to change the signature of this function; I think
that's fine.

Test plan: Unit tests added. (Also, it's really simple.)
@decentralion decentralion force-pushed the github-login-address branch from 22b2743 to 7767bea Sep 18, 2019
@decentralion decentralion merged commit 1449935 into master Sep 18, 2019
2 checks passed
2 checks passed
ci/circleci: publish-1 Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
@decentralion decentralion deleted the github-login-address branch Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.