Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD Cred per contributor for each period. #3236

Merged
merged 2 commits into from
Oct 21, 2021
Merged

ADD Cred per contributor for each period. #3236

merged 2 commits into from
Oct 21, 2021

Conversation

amrro
Copy link
Contributor

@amrro amrro commented Oct 21, 2021

Description

As per this Motivation, you can view each cred/contributor/period percentage.

Test Plan

Using yarn start and manually viewing it.

@amrro
Copy link
Contributor Author

amrro commented Oct 21, 2021

These numbers are buzzing me.
SourceCred has 0.1472043202747623 creds. But it got formatted to 0 cred. But % Cred is showing otherwise.

I think this will vanish in large data set, but it probably is going to happen more with contributors that have less than 0.5 creds, especially in week's beginning when the gap is not the big.

Screenshot from 2021-10-21 16-29-31

@amrro
Copy link
Contributor Author

amrro commented Oct 21, 2021

Closes #3163

@amrro amrro requested a review from blueridger October 21, 2021 18:13
@amrro amrro merged commit 261e48d into main Oct 21, 2021
@amrro amrro deleted the cred-per-contributor branch October 21, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants