From 05e3f0e5b88b56bfa4ccc97fb65a7d752e038ab1 Mon Sep 17 00:00:00 2001
From: Gadfly <gadfly@gadfly.vip>
Date: Sat, 15 Mar 2025 22:13:10 +0800
Subject: [PATCH 1/2] enhance: add tooltips to various UI elements for better
 accessibility

---
 src/Converters/StringConverters.cs   |  3 +++
 src/Views/ChangeCollectionView.axaml | 13 ++++++++++---
 src/Views/DiffView.axaml             |  2 +-
 src/Views/Histories.axaml            | 11 +++++++++--
 src/Views/RevisionFiles.axaml        |  2 +-
 5 files changed, 24 insertions(+), 7 deletions(-)

diff --git a/src/Converters/StringConverters.cs b/src/Converters/StringConverters.cs
index 5e4608c52..c371b859f 100644
--- a/src/Converters/StringConverters.cs
+++ b/src/Converters/StringConverters.cs
@@ -81,5 +81,8 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu
 
         public static readonly FuncValueConverter<string, bool> ContainsSpaces =
             new FuncValueConverter<string, bool>(v => v != null && v.Contains(' '));
+        
+        public static readonly FuncValueConverter<Models.User, string> UserToString =
+            new FuncValueConverter<Models.User, string>(v => v == null ? string.Empty : $"{v.Name} <{v.Email}>");
     }
 }
diff --git a/src/Views/ChangeCollectionView.axaml b/src/Views/ChangeCollectionView.axaml
index 6ce3d0336..2b0f5bfac 100644
--- a/src/Views/ChangeCollectionView.axaml
+++ b/src/Views/ChangeCollectionView.axaml
@@ -39,7 +39,8 @@
             <Grid ColumnDefinitions="16,Auto,Auto,*"
                   Margin="{Binding Depth, Converter={x:Static c:IntConverters.ToTreeMargin}}"
                   Background="Transparent"
-                  DoubleTapped="OnRowDoubleTapped">
+                  DoubleTapped="OnRowDoubleTapped"
+                  ToolTip.Tip="{Binding FullPath}">
               <v:ChangeTreeNodeToggleButton Grid.Column="0"
                                             Classes="tree_expander"
                                             Focusable="False"
@@ -71,7 +72,10 @@
                                    SelectionChanged="OnRowSelectionChanged">
         <ListBox.ItemTemplate>
           <DataTemplate DataType="m:Change">
-            <Grid ColumnDefinitions="Auto,Auto,Auto,*" Background="Transparent" DoubleTapped="OnRowDoubleTapped">
+            <Grid ColumnDefinitions="Auto,Auto,Auto,*"
+                  Background="Transparent"
+                  DoubleTapped="OnRowDoubleTapped"
+                  ToolTip.Tip="{Binding Path}">
               <v:ChangeStatusIcon Grid.Column="0"
                                   Width="14" Height="14"
                                   Margin="4,0,0,0"
@@ -100,7 +104,10 @@
                                    SelectionChanged="OnRowSelectionChanged">
         <ListBox.ItemTemplate>
           <DataTemplate DataType="m:Change">
-            <Grid ColumnDefinitions="Auto,Auto,*" Background="Transparent" DoubleTapped="OnRowDoubleTapped">
+            <Grid ColumnDefinitions="Auto,Auto,*"
+                  Background="Transparent"
+                  DoubleTapped="OnRowDoubleTapped"
+                  ToolTip.Tip="{Binding Path}">
               <v:ChangeStatusIcon Grid.Column="0"
                                   Width="14" Height="14"
                                   Margin="4,0,0,0"
diff --git a/src/Views/DiffView.axaml b/src/Views/DiffView.axaml
index 2842715cf..8df3e4f60 100644
--- a/src/Views/DiffView.axaml
+++ b/src/Views/DiffView.axaml
@@ -30,7 +30,7 @@
           </Border>
 
           <!-- Title -->
-          <TextBlock Grid.Column="2" Classes="primary" Margin="4,0,0,0" Text="{Binding Title}" FontSize="11" TextTrimming="CharacterEllipsis"/>
+          <TextBlock Grid.Column="2" Classes="primary" Margin="4,0,0,0" Text="{Binding Title}" ToolTip.Tip="{Binding Title}" FontSize="11" TextTrimming="CharacterEllipsis"/>
 
           <!-- Toolbar Buttons -->
           <StackPanel Grid.Column="3" Margin="8,0,0,0" Orientation="Horizontal" VerticalAlignment="Center">
diff --git a/src/Views/Histories.axaml b/src/Views/Histories.axaml
index 583e17c17..4bd0d54d6 100644
--- a/src/Views/Histories.axaml
+++ b/src/Views/Histories.axaml
@@ -126,7 +126,11 @@
                   </Grid.ColumnDefinitions>
 
                   <!-- Subject & REFS -->
-                  <Border Grid.Column="0" Padding="{Binding Margin}" ClipToBounds="True">
+                  <Border Grid.Column="0"
+                          Padding="{Binding Margin}"
+                          ClipToBounds="True"
+                          Background="Transparent"
+                          ToolTip.Tip="{Binding Subject}">
                     <Grid ColumnDefinitions="Auto,Auto,*" Margin="2,0,4,0" ClipToBounds="True">
                       <v:CommitStatusIndicator Grid.Column="0" 
                                                CurrentBranch="{Binding $parent[v:Histories].CurrentBranch}"
@@ -159,7 +163,10 @@
                   </Border>
 
                   <!-- Author -->
-                  <Grid Grid.Column="1" ColumnDefinitions="20,*" IsHitTestVisible="False">
+                  <Grid Grid.Column="1"
+                        ColumnDefinitions="20,*"
+                        Background="Transparent"
+                        ToolTip.Tip="{Binding Author, Converter={x:Static c:StringConverters.UserToString}}">
                     <v:Avatar Grid.Column="0"
                               Width="16" Height="16"
                               Margin="4,0,0,0"
diff --git a/src/Views/RevisionFiles.axaml b/src/Views/RevisionFiles.axaml
index ed381bf84..e0c6577d6 100644
--- a/src/Views/RevisionFiles.axaml
+++ b/src/Views/RevisionFiles.axaml
@@ -46,7 +46,7 @@
                HorizontalOffset="-8" VerticalAlignment="-8">
           <Popup.IsOpen>
             <MultiBinding Converter="{x:Static BoolConverters.And}">
-              <Binding Path="RevisionFileSearchSuggestion" Converter="{x:Static c:ListConverters.IsNotNullOrEmpty}}"/>
+              <Binding Path="RevisionFileSearchSuggestion" Converter="{x:Static c:ListConverters.IsNotNullOrEmpty}"/>
               <Binding Path="$parent[Window].IsActive"/>
             </MultiBinding>
           </Popup.IsOpen>

From 37f8049521c0b43a149fea5f6344a1ed4e69f183 Mon Sep 17 00:00:00 2001
From: Gadfly <gadfly@gadfly.vip>
Date: Sat, 15 Mar 2025 22:19:13 +0800
Subject: [PATCH 2/2] refactor: simplify user string conversion

---
 src/Converters/StringConverters.cs | 3 ---
 src/Models/User.cs                 | 5 +++++
 src/Views/Histories.axaml          | 2 +-
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/src/Converters/StringConverters.cs b/src/Converters/StringConverters.cs
index c371b859f..5e4608c52 100644
--- a/src/Converters/StringConverters.cs
+++ b/src/Converters/StringConverters.cs
@@ -81,8 +81,5 @@ public object ConvertBack(object value, Type targetType, object parameter, Cultu
 
         public static readonly FuncValueConverter<string, bool> ContainsSpaces =
             new FuncValueConverter<string, bool>(v => v != null && v.Contains(' '));
-        
-        public static readonly FuncValueConverter<Models.User, string> UserToString =
-            new FuncValueConverter<Models.User, string>(v => v == null ? string.Empty : $"{v.Name} <{v.Email}>");
     }
 }
diff --git a/src/Models/User.cs b/src/Models/User.cs
index 850bcf2ff..066ab7476 100644
--- a/src/Models/User.cs
+++ b/src/Models/User.cs
@@ -43,6 +43,11 @@ public static User FindOrAdd(string data)
             return _caches.GetOrAdd(data, key => new User(key));
         }
 
+        public override string ToString()
+        {
+            return $"{Name} <{Email}>";
+        }
+
         private static ConcurrentDictionary<string, User> _caches = new ConcurrentDictionary<string, User>();
         private readonly int _hash;
     }
diff --git a/src/Views/Histories.axaml b/src/Views/Histories.axaml
index 4bd0d54d6..afe2c1b73 100644
--- a/src/Views/Histories.axaml
+++ b/src/Views/Histories.axaml
@@ -166,7 +166,7 @@
                   <Grid Grid.Column="1"
                         ColumnDefinitions="20,*"
                         Background="Transparent"
-                        ToolTip.Tip="{Binding Author, Converter={x:Static c:StringConverters.UserToString}}">
+                        ToolTip.Tip="{Binding Author}">
                     <v:Avatar Grid.Column="0"
                               Width="16" Height="16"
                               Margin="4,0,0,0"