This repository was archived by the owner on Sep 11, 2025. It is now read-only.
Add initial component design and review process #1381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinaforney
approved these changes
Aug 10, 2020
Co-authored-by: Christina Forney <christina@sourcegraph.com>
quinnkeast
approved these changes
Aug 13, 2020
Contributor
quinnkeast
left a comment
quinnkeast
left a comment
There was a problem hiding this comment.
I'm a big fan of this approach, because it means we don't have to make changes to the component system or tooling until we're confident they're meaningful and complete.
AlicjaSuska
reviewed
Aug 17, 2020
Contributor
|
@rrhyne should we merge this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a very brief and introductory description of how a new component should be requested and approved.