Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIIP: Lyft case study v1 draft #301

Closed
wants to merge 0 commits into from

Conversation

@ryan-blunden
Copy link
Contributor

ryan-blunden commented Nov 4, 2019

No description provided.

@ryan-blunden ryan-blunden self-assigned this Nov 4, 2019
@ryan-blunden ryan-blunden changed the title Lyft case study v1 draft WIIP: Lyft case study v1 draft Nov 4, 2019
@ryan-blunden ryan-blunden marked this pull request as ready for review Nov 4, 2019
@dadlerj

This comment has been minimized.

Copy link
Member

dadlerj commented Nov 4, 2019

Not ready for review, I assume?

@ryan-blunden

This comment has been minimized.

Copy link
Contributor Author

ryan-blunden commented Nov 5, 2019

Not ready for review, I assume?

It's ready for Lyft to do their final review, but any other feedback related to code, punctuation, grammar etc. is welcome.

{/*This case study demonstrates how Lyft used Sourcegraph code search to aid in the decomposition of their 10 year old PHP monolith to microservices.*/}

<p>
This wasn't simply slicing up the monolith by domain into separate services—it was also a

This comment has been minimized.

Copy link
@vanesa

vanesa Nov 5, 2019

Member

Add blank on either side of the dash between services and it.

This comment has been minimized.

Copy link
@ryan-blunden

ryan-blunden Nov 5, 2019

Author Contributor

It's an em dash so typically, there is no space either side.

@vanesa
vanesa approved these changes Nov 5, 2019
Copy link
Member

vanesa left a comment

Just a spacing suggestion. Other than that, it's great! Looking forward to seeing this great testimony live!

Copy link
Member

dadlerj left a comment

Looks awesome!

@@ -58,30 +49,75 @@ hundreds of repositories, so a high level of accuracy is needed."
/>

<p>
Read on to learn how Lyft used Sourcegraph code search to provide a company wide verification
stage to confirm all call sites to previous monolith code had been updated before deploying to
Learn how Lyft used Sourcegraph code search to provide a company wide verification stage to

This comment has been minimized.

Copy link
@dadlerj

dadlerj Nov 5, 2019

Member

Can we get rid of this whole paragraph? It feels repetitive with the quote above it, and I worry people are more like to drop out when there's a lot of boilerplate at the start than if we just jump into the story.

@ryan-blunden ryan-blunden force-pushed the rb/lyft-case-study-1 branch from 5da43ef to 035e609 Nov 5, 2019
@ryan-blunden ryan-blunden force-pushed the rb/lyft-case-study-1 branch from 035e609 to ec229d0 Nov 5, 2019
@ryan-blunden ryan-blunden force-pushed the rb/lyft-case-study-1 branch from ec229d0 to e94a799 Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.