Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add gitlab integration blog post #332

Merged
merged 6 commits into from Nov 12, 2019
Merged

Conversation

@vanesa
Copy link
Member

vanesa commented Nov 12, 2019

image

Banner alternative:
gitlab-integration-symbols-banner-dark

Preview thumbnails on blog page:
gitlab-integration-symbols-preview-dark
gitlab-integration-preview-dark

<br>
<br>

Over 100,000 organizations use GitLab to manage their DevOps lifecycle. Today GitLab announced a collaboration with Sourcegraph to make code navigation and code intelligence available to all GitLab users, integrated seamlessly in the GitLab developer workflow and user interface.

This comment has been minimized.

Copy link
@dadlerj

dadlerj Nov 12, 2019

Member

Can we update this to link to their blog post when it goes live?

This comment has been minimized.

Copy link
@vanesa

vanesa Nov 12, 2019

Author Member

Ok!

…-sourcegraph.md

Co-Authored-By: Dan Adler <dadlerj@users.noreply.github.com>
Copy link
Contributor

ryan-blunden left a comment

@vanesa All images need to go in the static directory, not the blogposts directory.

**What languages does this support?**
<br>
The integration supports the [25 most used programming languages](https://sourcegraph.com/extensions?query=category%3A%22Programming+languages%22):<br>
Clojure<br>

This comment has been minimized.

Copy link
@ryan-blunden

ryan-blunden Nov 12, 2019

Contributor

This needs to be an unordered list.

Ideally, we use the images from the Sourcegraph language extensions list and display them as tiles to make this more visually appealing.

This comment has been minimized.

Copy link
@vanesa

vanesa Nov 12, 2019

Author Member

@ryan-blunden If we only use images it defeats the purpose of SEO. Should I switch this file to a tsx file since md is a bit restrictive with lists?

This comment has been minimized.

Copy link
@ryan-blunden

ryan-blunden Nov 12, 2019

Contributor

I don't think the languages in and of themselves will add significant SEO value here, but you could add the language text to a span with a class of "sr-only", or at least alt text to each image. Would just look a lot nicer.

Should I switch this file to a tsx file since md is a bit restrictive with lists?

If you were going to do the language tiles, you can insert the raw HTML. It's great to strive to only use Markup syntax, but it's designed to be flexible by accepting HTML when needed.

Copy link
Contributor

ryan-blunden left a comment

@vanesa Are 4 images required or just 2?

vanesa and others added 3 commits Nov 12, 2019
@christinaforney christinaforney force-pushed the vo/gitlab-integration-blog-post branch from c2f921a to c080a0d Nov 12, 2019
Copy link
Member

christinaforney left a comment

Final edits are in!

@christinaforney christinaforney merged commit 7f1dce9 into master Nov 12, 2019
5 checks passed
5 checks passed
Header rules No header rules processed
Details
Pages changed 7 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 77 redirect rules processed
Details
deploy/netlify Deploy preview ready!
Details
@christinaforney christinaforney deleted the vo/gitlab-integration-blog-post branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.