Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newsletter signup form to footer #642

Merged
merged 3 commits into from Mar 12, 2020
Merged

Conversation

@ryan-blunden
Copy link
Contributor

ryan-blunden commented Mar 5, 2020

Screen Shot 2020-03-05 at 4 45 52 PM

@ryan-blunden ryan-blunden requested review from aileenrose, vanesa and attfarhan Mar 5, 2020
@ryan-blunden ryan-blunden self-assigned this Mar 5, 2020
Copy link
Member

vanesa left a comment

Could we put this in a box instead of subtly showing it with the same background as the footer navigation? When I first saw it, I thought it was just some legal disclaimer and didn't realize it was a CTA to sign up for the newsletter.

@ryan-blunden

This comment has been minimized.

Copy link
Contributor Author

ryan-blunden commented Mar 5, 2020

I think it's ok to merge so long as it's not detrimental to the design, but agree that it doesn't stand out and could be improved. @aileenrose What do you think?

@aileenrose

This comment has been minimized.

Copy link
Contributor

aileenrose commented Mar 5, 2020

Could we put this in a box instead of subtly showing it with the same background as the footer navigation? When I first saw it, I thought it was just some legal disclaimer and didn't realize it was a CTA to sign up for the newsletter.

@vanesa - we can optimize the design over time. I would like to create additional CTAs on the blog landing page - which needs a bit of updating. :)

@ryan-blunden

This comment has been minimized.

Copy link
Contributor Author

ryan-blunden commented Mar 5, 2020

@aileenrose Can we redirect form submissions to a page on our site, as at the moment, it redirects to the ebook landing page.

Or better yet, is there a way we can submit without the user being redirected anywhere?

@creachadair creachadair changed the title Add neswletter signup form to footer Add newsletter signup form to footer Mar 5, 2020
Copy link
Contributor

aileenrose left a comment

Yes, this is v1. Looks good. Approved.

@ryan-blunden ryan-blunden merged commit 64b8d4a into master Mar 12, 2020
6 checks passed
6 checks passed
build
Details
Pages changed 832 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 84 redirect rules processed
Details
deploy/netlify Deploy preview ready!
Details
@ryan-blunden ryan-blunden deleted the rb-newsletter-subscribe-footer branch Mar 12, 2020
ryan-blunden added a commit that referenced this pull request Mar 16, 2020
This reverts commit 64b8d4a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.