This repository was archived by the owner on Sep 14, 2021. It is now read-only.
Return nil when a BoolOrString doesn't match #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrnugget
approved these changes
Jul 8, 2021
eseliger
approved these changes
Jul 8, 2021
LawnGnome
added a commit
to sourcegraph/src-cli
that referenced
this pull request
Jul 8, 2021
LawnGnome
added a commit
to sourcegraph/src-cli
that referenced
this pull request
Jul 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was something I missed when I made the earlier
srcchanges to support publish from UI: if there's a complexpublishedfield, then the fallback still goes tofalseif there's no repo/branch match, instead of the correctnil. There will be a corresponding src-cli PR momentarily to pull this in and ensure we replicate this behaviour on older Sourcegraph versions.