From a6614b6ad65a4174a1922b6ae28544903525cfa0 Mon Sep 17 00:00:00 2001 From: Eric Fritz Date: Wed, 31 Mar 2021 20:15:39 -0500 Subject: [PATCH 1/3] chore: fix comment reference --- src/hoverifier.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/hoverifier.ts b/src/hoverifier.ts index 3cd5ea3c..605bc0cc 100644 --- a/src/hoverifier.ts +++ b/src/hoverifier.ts @@ -667,8 +667,8 @@ export function createHoverifier({ * * Returns `undefined` if the hover result is not successful. * - * Uses the range specified by the hover result if present, or `position` oherwise, - * which will be expanded into a full token in getTokenAtPosition(). + * Uses the range specified by the hover result if present, or `position` otherwise, + * which will be expanded into a full token in getTokenAtPositionOrRange(). */ const getHighlightedRange = ({ hoverOrError, From edab34045045582c69a36f45e947af5e07a4c631 Mon Sep 17 00:00:00 2001 From: Eric Fritz Date: Wed, 31 Mar 2021 20:27:53 -0500 Subject: [PATCH 2/3] fix: half-closed intervals --- src/hoverifier.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hoverifier.ts b/src/hoverifier.ts index 605bc0cc..dc8fcc65 100644 --- a/src/hoverifier.ts +++ b/src/hoverifier.ts @@ -687,7 +687,7 @@ export function createHoverifier({ }, end: { line: hoverOrError.range.end.line + 1, - character: hoverOrError.range.end.character + 1, + character: hoverOrError.range.end.character, }, } } From 1f4619b9f616b2cac120d2811676e38a55ffa388 Mon Sep 17 00:00:00 2001 From: Eric Fritz Date: Wed, 31 Mar 2021 20:35:14 -0500 Subject: [PATCH 3/3] fix: update test values --- src/hoverifier.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/hoverifier.test.ts b/src/hoverifier.test.ts index 2249f588..94684b1f 100644 --- a/src/hoverifier.test.ts +++ b/src/hoverifier.test.ts @@ -50,7 +50,7 @@ describe('Hoverifier', () => { const delayTime = 100 const hoverRange = { start: { line: 1, character: 2 }, end: { line: 3, character: 4 } } - const hoverRange1Indexed = { start: { line: 2, character: 3 }, end: { line: 4, character: 5 } } + const hoverRange1Indexed = { start: { line: 2, character: 3 }, end: { line: 4, character: 4 } } scheduler.run(({ cold, expectObservable }) => { const hoverifier = createHoverifier({