Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRD: [VSC] Edit command #1658

Closed
14 tasks done
taylorsperry opened this issue Nov 6, 2023 · 7 comments
Closed
14 tasks done

PRD: [VSC] Edit command #1658

taylorsperry opened this issue Nov 6, 2023 · 7 comments

Comments

@taylorsperry
Copy link
Contributor

taylorsperry commented Nov 6, 2023

Related Docs:

Description:

As a user, I want Cody to edit my code according to my instructions.

Objectives:

Provide an easily discoverable, pre-packaged prompt that allows Cody to edit users' code according to their instructions.

Acceptance Criteria:

Acceptance Criteria

Design Tasks:

Design Tasks

No tasks being tracked yet.

Engineering Tasks:

Engineering Tasks

  1. dec-ga/vscode
    toolmantim umpox
  2. dec-ga/vscode dec-ga: commands-ux-polish
    umpox
  3. car: reduced-chat-commands-latency clients/jetbrains clients/vscode dec-ga/vscode perf
    umpox
  4. umpox
  5. umpox
  6. umpox
  7. umpox
  8. umpox
  9. umpox
  10. umpox

Follow-up Tasks:

After GA Tasks:

After GA

No tasks being tracked yet.
@kalanchan
Copy link
Contributor

this is done, will confirm with Beyang

edit command:
CleanShot 2023-11-07 at 14 25 22@2x

diff view:
CleanShot 2023-11-07 at 14 26 31@2x

edit applied, undo, done:
CleanShot 2023-11-07 at 14 27 25@2x

@kalanchan kalanchan changed the title PRD-Issue: [VSC] Edit command PRD: [VSC] Edit command Nov 10, 2023
@taylorsperry
Copy link
Contributor Author

taylorsperry commented Nov 13, 2023

Version v0.15.1699888090

  • ✅ In the open project file, Cody automatically applies edits to the selected code, per the user’s instructions
  • ❌ Users can see a diff view of the edit
  • ❌ Users can undo an edit
  • The edit command can be triggered from:
    • ✅ the sidebar
    • ✅ right-click menu
    • ✅ keyboard shortcut

When I tried this the lens (is that what it's called?) to retry / undo / see diff disappeared before I could even click on them. See Loom.

I also ran into some weird/inconsistent behavior in which Cody didn't always apply my edits:

  • I highlighted some code, used the Edit command to ask Cody to add a new input, and saw this behavior (Cody just added two <selectedCode> and </selectedCode> tags. Loom.
  • Cody also didn’t consistently perform the edit at all. Loom

@kalanchan
Copy link
Contributor

@taylorsperry can you show screenshots of being unable to see the diff view and unable to undo an edit?

In my comments above I've captured where that functionality is

@taylorsperry
Copy link
Contributor Author

taylorsperry commented Nov 15, 2023

@kalanchan do the looms I linked in my comment not do the trick? Hard to take a screenshot of something that's disappearing 🤣

@umpox
Copy link
Contributor

umpox commented Nov 16, 2023

@taylorsperry Do you have files.autoSave set in your VS Code settings by any chance? The code lens goes away on save so it might be related to that 🤔

Maybe we should disable it if that setting is true.

@umpox
Copy link
Contributor

umpox commented Nov 16, 2023

I highlighted some code, used the Edit command to ask Cody to add a new input, and saw this behavior (Cody just added two and tags.

PR to fix: #1765

@umpox
Copy link
Contributor

umpox commented Nov 16, 2023

@taylorsperry PR to fix the disappearing retry/undo/diff options: #1767

I believe this should fix the issue (it seems like the file auto saved from watching your loom). Would appreciate another test either on the branch or when this fix is released if you have chance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants