fix: remove codyProEnabled field from GraphQL API call #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chwarwick
reviewed
Jan 11, 2024
| @@ -262,6 +262,7 @@ export class AuthProvider { | |||
| } | |||
|
|
|||
| const isCodyEnabled = true | |||
| const proStatus = await this.client.getCurrentUserCodyProEnabled() | |||
There was a problem hiding this comment.
So am I following this right in the enterprise proStatus = Error('current user not found') which makes the userCanUpgrade false?
There was a problem hiding this comment.
but it never gets that far because isDotCom is false anyway.
There was a problem hiding this comment.
Yea this is only called below when isDotCom is true
chwarwick
approved these changes
Jan 11, 2024
CleanShot.2024-01-10.at.16.48.26.mp4looks good, I logged into |
kalanchan
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RE: https://sourcegraph.slack.com/archives/C05MW2TMYAV/p1704927255975299
Fix issues where enterprise users are unable to login due when on an older version of Sourcegraph.
Remove codyProEnabled field from GraphQL API call as it's used for both enterprise and dot com users, which does not exist in older enterprise instances.
Test plan
updating tests